Skip to content

apollo_consensus_orchestrator: tmp dirty tests for SNIP-35 (NOT FOR MERGE)#13857

Open
sirandreww-starkware wants to merge 1 commit into04-26-apollo_l1_gas_price_apollo_l1_gas_price_config_move_exchange_rate_decimals_const_to_configfrom
04-20-tmp_dirty_tests_for_snip35
Open

apollo_consensus_orchestrator: tmp dirty tests for SNIP-35 (NOT FOR MERGE)#13857
sirandreww-starkware wants to merge 1 commit into04-26-apollo_l1_gas_price_apollo_l1_gas_price_config_move_exchange_rate_decimals_const_to_configfrom
04-20-tmp_dirty_tests_for_snip35

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

This was referenced Apr 23, 2026
Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented Apr 23, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sirandreww-starkware sirandreww-starkware changed the base branch from 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests to graphite-base/13857 April 26, 2026 09:32
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-tmp_dirty_tests_for_snip35 branch 2 times, most recently from 6a39956 to f8e5bc6 Compare April 28, 2026 07:38
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests branch from 48af245 to 3dbd20f Compare April 28, 2026 07:51
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-tmp_dirty_tests_for_snip35 branch from f8e5bc6 to 628b687 Compare April 28, 2026 07:51
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests branch from 3dbd20f to c6c5c87 Compare April 28, 2026 08:30
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-tmp_dirty_tests_for_snip35 branch from 628b687 to dd5b00f Compare April 28, 2026 08:30
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests branch from c6c5c87 to e0c65d9 Compare April 28, 2026 11:29
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-tmp_dirty_tests_for_snip35 branch from dd5b00f to 8b01a71 Compare April 28, 2026 11:29
@sirandreww-starkware sirandreww-starkware self-assigned this Apr 28, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review April 28, 2026 12:30
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 28, 2026

PR Summary

Medium Risk
Test-only additions but very large and simulation-heavy (fuzz/long-running tokio tests), which may increase CI time and introduce flakiness/timeouts.

Overview
Adds extensive SNIP-35 test coverage under #[cfg(test)], including a new snip35_stress_test suite that stress-tests median/target/proposal math, overflow/clamping behavior, adversarial proposals, and sharp oracle-driven price changes.

Adds a separate snip35_integration_test module that simulates multi-node consensus scenarios (mixed upgraded/non-upgraded nodes, oracle disagreement/outages, forks, backfill), and includes a consensus_flow harness that drives the real proposal/decision cycle and asserts the emitted fee_proposal_fri matches the SNIP-35 formula over multiple heights.

Reviewed by Cursor Bugbot for commit 5d2a6e1. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-tmp_dirty_tests_for_snip35 branch from 8b01a71 to b67fcd7 Compare April 30, 2026 11:45
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests branch from e0c65d9 to 64af760 Compare April 30, 2026 11:45
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-tmp_dirty_tests_for_snip35 branch 2 times, most recently from da623ca to b892c68 Compare April 30, 2026 13:49
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests branch from 65f826d to 8148825 Compare April 30, 2026 13:49
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-tmp_dirty_tests_for_snip35 branch from b892c68 to 87b0a74 Compare May 1, 2026 15:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests branch from 8148825 to 6768f3a Compare May 1, 2026 15:11
@sirandreww-starkware sirandreww-starkware changed the base branch from 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests to graphite-base/13857 May 1, 2026 15:44
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-tmp_dirty_tests_for_snip35 branch from 87b0a74 to 31202eb Compare May 1, 2026 15:54
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13857 to 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests May 1, 2026 15:55
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-tmp_dirty_tests_for_snip35 branch from 31202eb to 55cfd66 Compare May 1, 2026 15:59
@sirandreww-starkware sirandreww-starkware changed the base branch from 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests to graphite-base/13857 May 1, 2026 16:15
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-tmp_dirty_tests_for_snip35 branch from 55cfd66 to f79d8b2 Compare May 1, 2026 16:15
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13857 to 04-26-apollo_l1_gas_price_apollo_l1_gas_price_config_move_exchange_rate_decimals_const_to_config May 1, 2026 16:16
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

Artifacts upload workflows:

@sirandreww-starkware sirandreww-starkware force-pushed the 04-26-apollo_l1_gas_price_apollo_l1_gas_price_config_move_exchange_rate_decimals_const_to_config branch from 102b640 to a212b4d Compare May 1, 2026 17:08
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-tmp_dirty_tests_for_snip35 branch from f79d8b2 to 5d2a6e1 Compare May 1, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants