Skip to content

apollo_consensus_orchestrator: add SNIP-35 proposer-validator symmetry tests#13856

Open
sirandreww-starkware wants to merge 1 commit into04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_testsfrom
04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests
Open

apollo_consensus_orchestrator: add SNIP-35 proposer-validator symmetry tests#13856
sirandreww-starkware wants to merge 1 commit into04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_testsfrom
04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

This was referenced Apr 23, 2026
Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented Apr 23, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests branch 2 times, most recently from a31cf0a to ffc6125 Compare April 27, 2026 12:10
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch from 1632dd1 to e044895 Compare April 27, 2026 12:39
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests branch 2 times, most recently from d2f9290 to 7bb5e34 Compare April 27, 2026 12:54
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch 2 times, most recently from 4056c10 to e878ca6 Compare April 28, 2026 07:38
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests branch 4 times, most recently from c6c5c87 to e0c65d9 Compare April 28, 2026 11:29
@sirandreww-starkware sirandreww-starkware self-assigned this Apr 28, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review April 28, 2026 12:29
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 28, 2026

PR Summary

Medium Risk
Mostly adds dev-only tests, but also updates Cargo.lock (including cairo-native rc bump and transitive crate version shifts) which can affect build reproducibility and CI behavior.

Overview
Adds SNIP-35 proposer/validator symmetry coverage by introducing a local validator_accepts predicate and new tests that assert out-of-bounds fee_proposal values are rejected while compute_fee_proposal outputs always pass the same bounds (via deterministic fuzzing with ChaCha8Rng).

Updates apollo_consensus_orchestrator dev-dependencies to include rand/rand_chacha, and refreshes Cargo.lock (notably bumping cairo-native to 0.9.0-rc.6 and adjusting several transitive versions such as ahash, hashbrown, and windows-sys).

Reviewed by Cursor Bugbot for commit 95db906. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests branch from e0c65d9 to 64af760 Compare April 30, 2026 11:45
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch 2 times, most recently from 3703133 to e47ed58 Compare April 30, 2026 12:25
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests branch 2 times, most recently from 65f826d to 8148825 Compare April 30, 2026 13:49
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch from e47ed58 to 5a8d107 Compare April 30, 2026 13:49
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests branch from 8148825 to 6768f3a Compare May 1, 2026 15:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch from 3e9abcc to 023f163 Compare May 1, 2026 15:44
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests branch from 6768f3a to 2d7839e Compare May 1, 2026 15:44
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch from 023f163 to f358d9a Compare May 1, 2026 15:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests branch from 2d7839e to 045b217 Compare May 1, 2026 15:59
@sirandreww-starkware sirandreww-starkware changed the base branch from 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests to graphite-base/13856 May 1, 2026 17:05
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_proposer-validator_symmetry_tests branch from 045b217 to 95db906 Compare May 1, 2026 17:08
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13856 to 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests May 1, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants