Skip to content

apollo_l1_gas_price: rename EthToStrkOracleClient to PriceOracleClient#13805

Closed
sirandreww-starkware wants to merge 1 commit into04-19-apollo_l1_gas_price_config_rename_ethtostrkoracleconfig_to_priceoracleconfigfrom
04-19-apollo_l1_gas_price_rename_ethtostrkoracleclient_to_priceoracleclient
Closed

apollo_l1_gas_price: rename EthToStrkOracleClient to PriceOracleClient#13805
sirandreww-starkware wants to merge 1 commit into04-19-apollo_l1_gas_price_config_rename_ethtostrkoracleconfig_to_priceoracleconfigfrom
04-19-apollo_l1_gas_price_rename_ethtostrkoracleclient_to_priceoracleclient

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented Apr 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_l1_gas_price_config_rename_ethtostrkoracleconfig_to_priceoracleconfig branch from 2d07315 to e57394b Compare April 23, 2026 11:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_l1_gas_price_rename_ethtostrkoracleclient_to_priceoracleclient branch from 6e03598 to abab4ef Compare April 23, 2026 11:59
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 26, 2026

PR Summary

Low Risk
Low risk rename-only change: updates type names and call sites without changing oracle query/caching logic. Main risk is missed references causing compile or integration breakages in downstream crates.

Overview
Renames the ETH→STRK oracle client type from EthToStrkOracleClient to PriceOracleClient and updates its PriceOracleClientTrait implementation accordingly.

All internal call sites are updated to use the new name, including the oracle unit tests and L1GasPriceProvider::new_with_oracle construction path.

Reviewed by Cursor Bugbot for commit abab4ef. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants