Skip to content

apollo_l1_gas_price: rename ETH_TO_STRK_QUANTIZATION to ORACLE_PRICE_DECIMALS#13807

Closed
sirandreww-starkware wants to merge 1 commit into04-19-apollo_l1_gas_price_rename_eth_to_strk_oracle.rs_to_price_oracle.rsfrom
04-19-apollo_l1_gas_price_rename_eth_to_strk_quantization_to_oracle_price_decimals
Closed

apollo_l1_gas_price: rename ETH_TO_STRK_QUANTIZATION to ORACLE_PRICE_DECIMALS#13807
sirandreww-starkware wants to merge 1 commit into04-19-apollo_l1_gas_price_rename_eth_to_strk_oracle.rs_to_price_oracle.rsfrom
04-19-apollo_l1_gas_price_rename_eth_to_strk_quantization_to_oracle_price_decimals

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented Apr 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_l1_gas_price_rename_eth_to_strk_oracle.rs_to_price_oracle.rs branch from 5a83e69 to c5109d4 Compare April 23, 2026 11:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_l1_gas_price_rename_eth_to_strk_quantization_to_oracle_price_decimals branch from 7e58ab1 to 2973d81 Compare April 23, 2026 11:59
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 26, 2026

PR Summary

Low Risk
Low risk rename-only change; behavior remains the same (still enforces 18 decimals) with updates to integration test oracle mocks and validation checks.

Overview
Renames the eth-to-STRK price oracle decimals constant from ETH_TO_STRK_QUANTIZATION to ORACLE_PRICE_DECIMALS and updates callers accordingly.

Integration tests’ fake oracle response and the PriceOracleClient decimals validation now reference the new constant while continuing to require 18 decimals.

Reviewed by Cursor Bugbot for commit e27f83f. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_l1_gas_price_rename_eth_to_strk_quantization_to_oracle_price_decimals branch from 2973d81 to e27f83f Compare April 26, 2026 09:32
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants