Skip to content

apollo_l1_gas_price_types: rename get_eth_to_fri_rate to get_price on provider client#13803

Closed
sirandreww-starkware wants to merge 1 commit into04-19-apollo_l1_gas_price_types_rename_ethtostrkoracleclienttrait_to_priceoracleclienttraitfrom
04-19-apollo_l1_gas_price_types_rename_get_eth_to_fri_rate_to_get_price_on_provider_client
Closed

apollo_l1_gas_price_types: rename get_eth_to_fri_rate to get_price on provider client#13803
sirandreww-starkware wants to merge 1 commit into04-19-apollo_l1_gas_price_types_rename_ethtostrkoracleclienttrait_to_priceoracleclienttraitfrom
04-19-apollo_l1_gas_price_types_rename_get_eth_to_fri_rate_to_get_price_on_provider_client

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented Apr 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Apr 19, 2026
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 26, 2026

PR Summary

Low Risk
Low risk rename-only API change, but it touches a shared trait method so any downstream implementers/callers must be updated to avoid compile/runtime mismatches.

Overview
Renames the L1GasPriceProviderClient API for fetching the ETH→FRI conversion rate from get_eth_to_fri_rate to get_price, and updates the concrete ComponentClient implementation accordingly.

Propagates the rename through consensus orchestrator code and tests (including mocks) so gas-price calculation continues to join! the conversion-rate fetch with get_price_info without changing behavior.

Reviewed by Cursor Bugbot for commit f25137f. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants