apollo_consensus_manager: wire STRK/USD oracle into consensus manager#13820
Conversation
6bd60bb to
8020f60
Compare
cfa6f7a to
10c280c
Compare
8020f60 to
c410076
Compare
10c280c to
209889b
Compare
79105cf to
d756021
Compare
bb0cb82 to
cec2942
Compare
397780c to
def2345
Compare
9d8504e to
befb7bc
Compare
04360da to
abc579f
Compare
befb7bc to
0bff93b
Compare
abc579f to
040849d
Compare
PR SummaryMedium Risk Overview Adds Reviewed by Cursor Bugbot for commit 74f5e86. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0bff93b. Configure here.
| // (safe but static). | ||
| strk_exchange_rate_oracle: Some(Arc::new(ExchangeRateOracleClient::new( | ||
| apollo_l1_gas_price_config::config::ExchangeRateOracleConfig::default(), | ||
| ))), |
There was a problem hiding this comment.
Always-failing oracle floods shared ETH_TO_STRK error metrics
Medium Severity
The new ExchangeRateOracleClient with the placeholder api.example.com URL will continuously fail, and each failure increments the global ETH_TO_STRK_ERROR_COUNT metric inside spawn_query. With lag_interval_seconds: 1 generating unique quantized timestamps, a new failing query is spawned on every block proposal (~every 3 seconds), producing ~1200 error increments per hour. The existing get_eth_to_strk_error_count_alert in alert_definitions.rs fires at a threshold of 10 per hour, so this will trigger constant false alerts and obscure genuine ETH/STRK oracle failures.
Reviewed by Cursor Bugbot for commit 0bff93b. Configure here.
0bff93b to
7d37870
Compare
040849d to
522bb06
Compare
7d37870 to
b15f099
Compare
522bb06 to
0948acf
Compare
b15f099 to
c693f3d
Compare
0948acf to
ab23186
Compare
c693f3d to
7280b48
Compare
ab23186 to
41b964d
Compare
7280b48 to
641991e
Compare
41b964d to
5896df2
Compare
641991e to
f802115
Compare
5896df2 to
ef7e93b
Compare
ef7e93b to
a965ac1
Compare
f802115 to
74f5e86
Compare



No description provided.