Skip to content

apollo_consensus_orchestrator,apollo_consensus_manager: add strk_exchange_rate_oracle field to deps#13823

Open
sirandreww-starkware wants to merge 1 commit into04-19-apollo_consensus_orchestrator_add_snip-35_metricsfrom
04-19-apollo_consensus_orchestrator_add_strk_price_oracle_field_to_deps
Open

apollo_consensus_orchestrator,apollo_consensus_manager: add strk_exchange_rate_oracle field to deps#13823
sirandreww-starkware wants to merge 1 commit into04-19-apollo_consensus_orchestrator_add_snip-35_metricsfrom
04-19-apollo_consensus_orchestrator_add_strk_price_oracle_field_to_deps

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

This was referenced Apr 19, 2026
Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented Apr 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch 2 times, most recently from 66e708d to a9c19ef Compare April 27, 2026 12:10
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_strk_price_oracle_field_to_deps branch from 71d2ddd to 43269b0 Compare April 27, 2026 12:10
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from a9c19ef to 25f8ccf Compare April 27, 2026 12:39
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_strk_price_oracle_field_to_deps branch from 43269b0 to 0b0b016 Compare April 27, 2026 12:39
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 25f8ccf to a308d67 Compare April 27, 2026 12:54
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_strk_price_oracle_field_to_deps branch 2 times, most recently from 884a9c9 to efce945 Compare April 28, 2026 07:38
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 03b1b6f to 8e3bb3b Compare April 28, 2026 07:51
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_strk_price_oracle_field_to_deps branch from efce945 to 0bae0ef Compare April 28, 2026 07:51
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 8e3bb3b to b9c3906 Compare April 28, 2026 08:30
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_strk_price_oracle_field_to_deps branch 2 times, most recently from 719f5eb to b217380 Compare April 28, 2026 11:29
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from b9c3906 to 574b1d0 Compare April 28, 2026 11:29
@sirandreww-starkware sirandreww-starkware self-assigned this Apr 28, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review April 28, 2026 12:27
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 28, 2026

PR Summary

Low Risk
Low risk: this is a dependency-wiring change only, adding an optional field that is currently passed as None and doesn’t alter consensus logic yet.

Overview
Adds an optional strk_exchange_rate_oracle dependency (typed as ExchangeRateOracleClientTrait) to SequencerConsensusContextDeps to support future SNIP-35 dynamic gas pricing.

Wires the new field through consensus manager and orchestrator test utilities, defaulting it to None so existing behavior remains unchanged.

Reviewed by Cursor Bugbot for commit cb5b659. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 574b1d0 to ff87b68 Compare April 30, 2026 11:45
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_strk_price_oracle_field_to_deps branch 2 times, most recently from 48bdd57 to 3f5a393 Compare April 30, 2026 12:25
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from ff87b68 to 0e781a5 Compare April 30, 2026 12:25
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from 0e781a5 to fce08ea Compare April 30, 2026 13:49
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_strk_price_oracle_field_to_deps branch 2 times, most recently from 29624cd to e0a29c8 Compare May 1, 2026 15:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_metrics branch from fce08ea to d5dcc22 Compare May 1, 2026 15:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_strk_price_oracle_field_to_deps branch 2 times, most recently from ec1e517 to 9c55e10 Compare May 1, 2026 15:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_strk_price_oracle_field_to_deps branch from 9c55e10 to cb5b659 Compare May 1, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants