Skip to content

apollo_l1_gas_price_types: rename EthToStrkOracleClientError to PriceOracleClientError#13801

Closed
sirandreww-starkware wants to merge 1 commit intomainfrom
04-19-apollo_l1_gas_price_types_rename_ethtostrkoracleclienterror_to_priceoracleclienterror
Closed

apollo_l1_gas_price_types: rename EthToStrkOracleClientError to PriceOracleClientError#13801
sirandreww-starkware wants to merge 1 commit intomainfrom
04-19-apollo_l1_gas_price_types_rename_ethtostrkoracleclienterror_to_priceoracleclienterror

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

This was referenced Apr 19, 2026
@sirandreww-starkware sirandreww-starkware self-assigned this Apr 20, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_l1_gas_price_types_rename_ethtostrkoracleclienterror_to_priceoracleclienterror branch from 36d4d38 to 92d8b69 Compare April 23, 2026 11:59
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 26, 2026

PR Summary

Low Risk
Low risk rename-only change that updates error type/variant wiring across crates and tests without changing runtime behavior.

Overview
Renames the oracle error type from EthToStrkOracleClientError to PriceOracleClientError in apollo_l1_gas_price_types and plumbs the new type through the eth-to-STRK oracle client, L1 gas price provider, and consensus orchestrator error enums.

Updates mocks/tests and error mapping (L1GasPriceProviderError/L1GasPriceClientError) to use the new error variant name, keeping the rest of the behavior the same.

Reviewed by Cursor Bugbot for commit 92d8b69. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on sirandreww-starkware).


a discussion (no related file):
Consider ExchangeRate instead of price (same for all PRs in the stack)

Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShahakShama made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on sirandreww-starkware).


a discussion (no related file):
Please unite PRs 13801 until 13809 to a single PR (all the eth to strk rename PRs)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants