Skip to content

apollo_consensus_orchestrator_config: rename validate_price_per_height to validate_dynamic_config#13810

Merged
sirandreww-starkware merged 1 commit intomainfrom
04-19-apollo_consensus_orchestrator_config_rename_validate_price_per_height_to_validate_dynamic_config
Apr 27, 2026
Merged

apollo_consensus_orchestrator_config: rename validate_price_per_height to validate_dynamic_config#13810
sirandreww-starkware merged 1 commit intomainfrom
04-19-apollo_consensus_orchestrator_config_rename_validate_price_per_height_to_validate_dynamic_config

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_l1_gas_price_apollo_consensus_orchestrator_rename_ethtostrkoracle_error_variants_and_log_message branch from de6aca0 to d75b26e Compare April 23, 2026 11:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_config_rename_validate_price_per_height_to_validate_dynamic_config branch from e05a52d to deb3f58 Compare April 23, 2026 11:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-26-apollo_l1_gas_price_deployment_rename_eth_to_strk_oracle_to_price_oracle branch from ee7c168 to 8956f60 Compare April 26, 2026 10:30
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_config_rename_validate_price_per_height_to_validate_dynamic_config branch from 317865f to 65b0bee Compare April 26, 2026 10:30
@sirandreww-starkware sirandreww-starkware force-pushed the 04-26-apollo_l1_gas_price_deployment_rename_eth_to_strk_oracle_to_price_oracle branch from 8956f60 to dfa93fd Compare April 26, 2026 10:42
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_config_rename_validate_price_per_height_to_validate_dynamic_config branch from 65b0bee to 19e2415 Compare April 26, 2026 10:42
@sirandreww-starkware sirandreww-starkware force-pushed the 04-26-apollo_l1_gas_price_deployment_rename_eth_to_strk_oracle_to_price_oracle branch from dfa93fd to c55e219 Compare April 26, 2026 13:01
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_config_rename_validate_price_per_height_to_validate_dynamic_config branch from 19e2415 to d44d2ce Compare April 26, 2026 13:01
@sirandreww-starkware sirandreww-starkware self-assigned this Apr 26, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review April 26, 2026 13:03
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 26, 2026

PR Summary

Low Risk
Low risk rename-only change to a config validation function, with no logic changes beyond the symbol name.

Overview
Updates ContextDynamicConfig to reference a renamed schema validator, changing the function name from validate_price_per_height to validate_dynamic_config while keeping the same validation checks.

Reviewed by Cursor Bugbot for commit 7dbd196. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_config_rename_validate_price_per_height_to_validate_dynamic_config branch from d44d2ce to b86e80e Compare April 26, 2026 13:26
@sirandreww-starkware sirandreww-starkware force-pushed the 04-26-apollo_l1_gas_price_deployment_rename_eth_to_strk_oracle_to_price_oracle branch from c55e219 to 2f781aa Compare April 26, 2026 13:26
Copy link
Copy Markdown
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware changed the base branch from 04-26-apollo_l1_gas_price_deployment_rename_eth_to_strk_oracle_to_price_oracle to graphite-base/13810 April 26, 2026 16:24
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_config_rename_validate_price_per_height_to_validate_dynamic_config branch from b86e80e to 0b466cf Compare April 26, 2026 16:24
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13810 to 04-26-apollo_l1_gas_price_apollo_l1_gas_price_config_move_exchange_rate_decimals_const_to_config April 26, 2026 16:24
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_config_rename_validate_price_per_height_to_validate_dynamic_config branch from 0b466cf to c77f96f Compare April 27, 2026 08:06
@sirandreww-starkware sirandreww-starkware force-pushed the 04-26-apollo_l1_gas_price_apollo_l1_gas_price_config_move_exchange_rate_decimals_const_to_config branch from af7a9a3 to 4c28248 Compare April 27, 2026 08:06
@sirandreww-starkware sirandreww-starkware changed the base branch from 04-26-apollo_l1_gas_price_apollo_l1_gas_price_config_move_exchange_rate_decimals_const_to_config to graphite-base/13810 April 27, 2026 10:31
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_config_rename_validate_price_per_height_to_validate_dynamic_config branch from c77f96f to 694e7c2 Compare April 27, 2026 10:31
@sirandreww-starkware sirandreww-starkware changed the base branch from graphite-base/13810 to main April 27, 2026 10:31
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_config_rename_validate_price_per_height_to_validate_dynamic_config branch from 694e7c2 to 7dbd196 Compare April 27, 2026 10:37
@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Apr 27, 2026
Merged via the queue into main with commit ea0f7c1 Apr 27, 2026
22 of 25 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants