apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into build_proposal

[sirandreww-starkware]

No description provided.

[sirandreww-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_consensus_orchestrator: tmp dirty tests for SNIP-35 (NOT FOR MERGE) #13857
• apollo_l1_gas_price,apollo_l1_gas_price_config: move exchange_rate_decimals const to config #13881
• apollo_consensus_orchestrator: add SNIP-35 proposer-validator symmetry tests #13856
• apollo_consensus_orchestrator: add SNIP-35 module edge case tests #13855
• apollo_consensus_orchestrator: add SNIP-35 e2e test #13821
• apollo_consensus_manager: wire STRK/USD oracle into consensus manager #13820
• apollo_consensus_orchestrator: add SNIP-35 fee_proposal validation #13819
• apollo_consensus_orchestrator: wire SNIP-35 fee_proposal into build_proposal #13818 👈 (View in Graphite)
• apollo_consensus_orchestrator: add fee_actual floor to EIP-1559 gas price calculation #13824
• apollo_consensus_orchestrator: add SNIP-35 fee_proposals sliding window #13817
• apollo_consensus_orchestrator,apollo_consensus_manager: add strk_exchange_rate_oracle field to deps #13823
• apollo_consensus_orchestrator: add SNIP-35 metrics #13816
• apollo_consensus_orchestrator: add SNIP-35 module tests #13815
• apollo_consensus_orchestrator: add SNIP-35 module #13854
• starknet_api: include fee_proposal_fri in proposal commitment hash #13814 : 1 other dependent PR (#13908 )
• apollo_storage: add fee_proposal_fri migrators and bump blocks version to 6.1 #13936 : 1 other dependent PR (#13934 )
• starknet_api: add fee_proposal_fri to BlockHeaderWithoutHash and PartialBlockHashComponents #13822
• apollo_protobuf: add fee_proposal_fri to ProposalInit #13812 : 2 other dependent PRs (#13811 , #13935 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[cursor]

PR Summary

Medium Risk
Touches consensus proposal-building and gas price adjustment paths; incorrect fee_proposal/fee_actual wiring or oracle fallback behavior could skew block headers and L2 gas pricing across nodes.

Overview
Wires SNIP-35 fees through proposal production: ProposalBuildArguments now carries fee_proposal and fee_actual, and build_proposal includes fee_proposal_fri in ProposalInit while using fee_actual as an additional floor when computing next_l2_gas_price.

SequencerConsensusContext now computes a per-block fee_proposal (using the STRK/USD oracle when available, otherwise freezing to fee_actual/current gas price), records SNIP-35 metrics, and persists the fee into state sync block headers. Test utilities are updated to populate the new build arguments, and snip35 adds constants for margin/target/oracle floor bounds used by the new computation.

^{Reviewed by Cursor Bugbot for commit 78fa661. Bugbot is set up for automated code reviews on this repo. Configure here.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 78fa661. Configure here.}

[cursor]

Propose and sync paths compute different block commitments

High Severity

Setting fee_proposal_fri to a non-zero value in ProposalInit and storing it in BlockHeaderWithoutHash creates a commitment mismatch between the propose and sync paths. During propose/validate, the batcher's PartialBlockHashComponents::new always uses GasPrice::default() (zero) for fee_proposal_fri when computing the commitment hash. But when a node syncs the same block, the batcher reconstructs PartialBlockHashComponents from the stored header using the actual non-zero value. Since fee_proposal_fri is part of the PartialBlockHash hash chain, these paths produce different ProposalCommitment values for the same block, corrupting prev_proposal_commitment on syncing nodes.

Additional Locations (1)

• crates/apollo_consensus_orchestrator/src/sequencer_consensus_context.rs#L368-L369

 

^{Reviewed by Cursor Bugbot for commit 78fa661. Configure here.}