Skip to content

apollo_consensus_orchestrator: add SNIP-35 module edge case tests#13855

Open
sirandreww-starkware wants to merge 1 commit into04-19-apollo_consensus_orchestrator_add_snip-35_e2e_testfrom
04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests
Open

apollo_consensus_orchestrator: add SNIP-35 module edge case tests#13855
sirandreww-starkware wants to merge 1 commit into04-19-apollo_consensus_orchestrator_add_snip-35_e2e_testfrom
04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests

Conversation

@sirandreww-starkware
Copy link
Copy Markdown
Contributor

No description provided.

@reviewable-StarkWare
Copy link
Copy Markdown

This change is Reviewable

This was referenced Apr 23, 2026
Copy link
Copy Markdown
Contributor Author

sirandreww-starkware commented Apr 23, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_e2e_test branch from d6462fc to a2a106a Compare April 27, 2026 12:54
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch from e044895 to 4056c10 Compare April 27, 2026 12:54
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_e2e_test branch from a2a106a to f11fe33 Compare April 28, 2026 07:38
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch from 4056c10 to e878ca6 Compare April 28, 2026 07:38
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_e2e_test branch from f11fe33 to 375e2ed Compare April 28, 2026 07:51
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch 2 times, most recently from 31bd0d1 to 4d136fb Compare April 28, 2026 08:30
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_e2e_test branch from 375e2ed to 1802fd0 Compare April 28, 2026 08:30
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch from 4d136fb to 7d860c7 Compare April 28, 2026 11:29
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_e2e_test branch from 1802fd0 to 56b4b6a Compare April 28, 2026 11:29
@sirandreww-starkware sirandreww-starkware self-assigned this Apr 28, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review April 28, 2026 12:29
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 28, 2026

PR Summary

Low Risk
Test-only changes that add coverage for overflow/saturation and adversarial/outlier scenarios in SNIP-35 fee computations; no production logic is modified.

Overview
Adds several edge-case tests for SNIP-35 fee computation helpers (compute_fee_actual, compute_fee_target, compute_fee_proposal).

The new coverage targets extreme u128 values/overflow resistance, non-panicking behavior under saturated arithmetic, monotonicity of compute_fee_target as STRK price changes, and robustness of the median against a single outlier.

Reviewed by Cursor Bugbot for commit 281d9af. Bugbot is set up for automated code reviews on this repo. Configure here.

@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_e2e_test branch from 56b4b6a to 9138a9c Compare April 30, 2026 11:45
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch from 7d860c7 to 3703133 Compare April 30, 2026 11:45
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3703133. Configure here.

Comment thread crates/apollo_consensus_orchestrator/src/snip35/test.rs
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch from 3703133 to e47ed58 Compare April 30, 2026 12:25
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_e2e_test branch 2 times, most recently from 29825da to 6637e70 Compare April 30, 2026 13:49
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch from e47ed58 to 5a8d107 Compare April 30, 2026 13:49
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_e2e_test branch from 6637e70 to d32e04b Compare May 1, 2026 15:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch from 5a8d107 to 3e9abcc Compare May 1, 2026 15:11
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_e2e_test branch from d32e04b to 1619ce1 Compare May 1, 2026 15:44
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch 2 times, most recently from 023f163 to f358d9a Compare May 1, 2026 15:59
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_e2e_test branch from 1619ce1 to dda2bb3 Compare May 1, 2026 15:59
@sirandreww-starkware sirandreww-starkware changed the title apollo_consensus_orchestrator: add SNIP-35 fee_market edge case tests apollo_consensus_orchestrator: add SNIP-35 module edge case tests May 1, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 04-19-apollo_consensus_orchestrator_add_snip-35_e2e_test branch from dda2bb3 to d62ef3c Compare May 1, 2026 17:05
@sirandreww-starkware sirandreww-starkware force-pushed the 04-20-apollo_consensus_orchestrator_add_snip-35_fee_market_edge_case_tests branch from f358d9a to 281d9af Compare May 1, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants