Allow linter configuration to filter graph diagnostics - #1000
Open
st0012 wants to merge 2 commits into
Open
Conversation
st0012
force-pushed
the
codex/configurable-graph-diagnostics
branch
from
August 11, 2026 20:12
0378f0b to
2b164df
Compare
st0012
marked this pull request as ready for review
August 11, 2026 20:16
Morriar
reviewed
Aug 12, 2026
| #: (Rubydex::LinterConfig config, Array[singleton(Rubydex::Linter::Rule)] known_rule_classes) -> void | ||
| def warn_unknown_rules(config, known_rule_classes) | ||
| known_rule_names = known_rule_classes.map(&:rule_name).uniq.sort | ||
| known_rule_names = (known_rule_classes.map(&:rule_name) + Rubydex::Diagnostic.graph_rule_names).uniq.sort |
Contributor
There was a problem hiding this comment.
I don't think we ever reach this point from the CLI if known_rule_classes is empty?
Contributor
There was a problem hiding this comment.
Let's add a test where the CLI without a rule should at least show the built-in diagnostics?
vinistock
reviewed
Aug 12, 2026
| /// | ||
| /// - `out_names` must be a valid, writable pointer. | ||
| #[unsafe(no_mangle)] | ||
| pub unsafe extern "C" fn rdx_graph_diagnostic_names(out_names: *mut *const *const c_char) -> usize { |
Member
There was a problem hiding this comment.
This looks like it belongs to Rule and not Diagnostic. Conceptually, a Rule is a type of mistake someone can make and a Diagnostic is an occurrence of that mistake.
If we want the names of the rules, so that they can be filtered, then shouldn't this method be in Rule? Like, Rule.all or Rule.built_in?
Assisted-By: devx/8c506d68-42fe-4150-abdf-cf627a09bef8
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to surface the graph rule diagnostics via linter because they are basically rules defined by us. But currently the linter configuration can't disable them, which is inconsistent and can create noise users don't want.
So in this PR, I implemented the plumbing to allow filtering graph diagnostics with linter configurations.
One difference is: when we disable a linter rule (say
MyLinterRule), that linter rule is not executed at all. If we do the same for the graph rule (sayinvalid-constant-visibility), the diagnostics can still be accessed via graph, but won't show up in the linter result.