Make diagnostic hold rule identity - #1015
Merged
Merged
Conversation
st0012
approved these changes
Aug 19, 2026
Morriar
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another step for #1000
Now that we have unified the concept of a rule identity under
Rule, we should revert the previous decision and store theRulesingleton in diagnostics. This allows us to make the modelling consistent with the Rust side and easily move the severity resolution after the collection (this will be relevant because we now have diagnostics that are collected differently, but we want to apply configuration to all of them in an uniform way).This PR changes diagnostics to hold a
Rulesingleton instead of just the name, so that we have access to the default severity and the name.