Make severity a Rule concern - #1004
Merged
Merged
Conversation
alexcrocha
approved these changes
Aug 14, 2026
st0012
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step towards #1000
We want to be able to configure and treat graph level diagnostics the same way as linter level diagnostics, but they are not implemented consistently right now. This is the first PR in a small series to make sure that the representations of
Rule,DiagnosticandRelatedInformationare all uniform across the codebase, so that we can truly treat them similarly.This PR does 2 primary things:
Ruleconcern. You configure the severity you desire for a class of mistakes, not for the individual occurrences of the mistake