Skip to content

Make severity a Rule concern - #1004

Merged
vinistock merged 1 commit into
mainfrom
vs_make_severity_a_rule_concern
Aug 14, 2026
Merged

Make severity a Rule concern#1004
vinistock merged 1 commit into
mainfrom
vs_make_severity_a_rule_concern

Conversation

@vinistock

Copy link
Copy Markdown
Member

First step towards #1000

We want to be able to configure and treat graph level diagnostics the same way as linter level diagnostics, but they are not implemented consistently right now. This is the first PR in a small series to make sure that the representations of Rule, Diagnostic and RelatedInformation are all uniform across the codebase, so that we can truly treat them similarly.

This PR does 2 primary things:

  1. On the Rust side, we made severity a diagnostic concern, when it should really be a Rule concern. You configure the severity you desire for a class of mistakes, not for the individual occurrences of the mistake
  2. We were using kebab case for the unique rule names, but that doesn't match the unique name used for linter rules. It's easier if we standardize on camel case, so that we have consistent naming

@vinistock vinistock self-assigned this Aug 13, 2026
@vinistock
vinistock requested a review from a team as a code owner August 13, 2026 20:55
@vinistock
vinistock merged commit e130577 into main Aug 14, 2026
36 checks passed
@vinistock
vinistock deleted the vs_make_severity_a_rule_concern branch August 14, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants