Move default_severity to the class level - #1006
Merged
Merged
Conversation
For unifying graph and linter diagnostics, having the default severity be an instance method is inconvenient because it would force graph rules to have to be instantiated with a graph and config object. Graph rules only hold a unique name and default severity, so moving this to the class level makes it easier to create a consistent model across the entire codebase.
st0012
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second step for #1000
For unifying graph and linter diagnostics, having the default severity be an instance method is
inconvenient because it would force graph rules to have to be instantiated with a graph and config object.
Graph rules only hold a unique name and default severity, so moving this to the class level makes it easier to create a consistent model across the entire codebase. Conceptually, it's almost correct as the default severity belongs to the definition of a rule and not its execution (instance).
We don't really lose anything in terms of type safety because we can still declare the singleton method as abstract.