Filter built-in and linter diagnostics uniformly - #1018
Merged
Conversation
Morriar
reviewed
Aug 20, 2026
vinistock
force-pushed
the
vs_unify_diagnostic_filtering
branch
from
August 20, 2026 17:08
5c7785a to
b51ec64
Compare
st0012
approved these changes
Aug 20, 2026
Morriar
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1000
This PR unifies the diagnostic filtering, so that built-in (graph) and linter diagnostics are treated consistently.
I also noticed that we were filtering based on path exclusions/inclusions separately 3 times, so I simplified the code to do it within the same loop, which is a bit easier to follow.
Lastly, I also renamed the glob flags constant. Not sure why we had a
RUBOCOPprefix, but we can probably remove it.