Skip to content

Comments

DuckDB lifetimes#6620

Merged
gatesn merged 16 commits intodevelopfrom
ji/ngates/duckdb-lifetimes
Feb 20, 2026
Merged

DuckDB lifetimes#6620
gatesn merged 16 commits intodevelopfrom
ji/ngates/duckdb-lifetimes

Conversation

@joseph-isaacs
Copy link
Contributor

@joseph-isaacs joseph-isaacs commented Feb 20, 2026

Closes #6581 with different naming convention

This PR removes the janky owned: bool flag and uses the same C API wrapping model as openssl.

We macro Foo and FooRef structs for owned and borrowed pointers respectively. Owned pointers invoke their destructor on drop.

gatesn and others added 16 commits February 17, 2026 22:26
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn force-pushed the ji/ngates/duckdb-lifetimes branch from c78fc3a to 7e29785 Compare February 20, 2026 21:29
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 20, 2026

Merging this PR will degrade performance by 27.45%

❌ 4 regressed benchmarks
✅ 949 untouched benchmarks
⏩ 1459 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 0.1)] 925.7 µs 1,091.7 µs -15.2%
Simulation take_map[(0.1, 0.05)] 769.8 µs 865 µs -11%
Simulation take_map[(0.1, 0.5)] 2.1 ms 2.6 ms -19.88%
Simulation take_map[(0.1, 1.0)] 3.5 ms 4.9 ms -27.45%

Comparing ji/ngates/duckdb-lifetimes (7e29785) with develop (99f2ce2)

Open in CodSpeed

Footnotes

  1. 1459 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn gatesn added the changelog/feature A new feature label Feb 20, 2026
@gatesn gatesn changed the title Ji/ngates/duckdb lifetimes DuckDB lifetimes Feb 20, 2026
@gatesn gatesn marked this pull request as ready for review February 20, 2026 21:37
@gatesn gatesn enabled auto-merge (squash) February 20, 2026 21:37
@gatesn gatesn merged commit 7827ffd into develop Feb 20, 2026
53 of 55 checks passed
@gatesn gatesn deleted the ji/ngates/duckdb-lifetimes branch February 20, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants