Skip to content

fix: Resolve pagination issue by fetching last content directly from the database #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PruthiviRaj27 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Resolve pagination issue by fetching last content directly from the database #798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/java/in/testpress/database/dao/ContentLiteDao.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ interface ContentLiteDao: BaseDao<ContentEntityLite> {
@Query("SELECT * FROM runningcontententity WHERE courseId = :courseId AND type = :type")
fun getRunningContents(courseId: Long, type: Int): PagingSource<Int, ContentEntityLite>

@Query("SELECT * FROM runningcontententity WHERE courseId = :courseId AND type = :type ORDER BY contentOrder DESC LIMIT 1")
suspend fun getLastContent(courseId: Long, type: Int): ContentEntityLite?

@Query("SELECT * FROM runningcontententity WHERE courseId = :courseId AND type = :type")
fun getUpcomingContents(courseId: Long, type: Int): PagingSource<Int, ContentEntityLite>

Expand Down
23 changes: 9 additions & 14 deletions course/src/main/java/in/testpress/course/pagination/CourseContentsRemoteMediator.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class CourseContentsRemoteMediator(
state: PagingState<Int, ContentEntityLite>
): MediatorResult {

pageNumber = getPageNumber(loadType,state)
pageNumber = getPageNumber(loadType)
if (pageNumber == -1) return MediatorResult.Success(endOfPaginationReached = true)

return try {
Expand All @@ -52,28 +52,23 @@ class CourseContentsRemoteMediator(
}
}

private suspend fun getPageNumber(
loadType: LoadType,
state: PagingState<Int, ContentEntityLite>
) : Int {
private suspend fun getPageNumber(loadType: LoadType) : Int {
return when (loadType) {
LoadType.REFRESH -> DEFAULT_PAGE_INDEX
LoadType.PREPEND -> -1
LoadType.APPEND -> getNextPageNumber(state)
LoadType.APPEND -> getNextPageNumber()
}
}

private suspend fun getNextPageNumber(state: PagingState<Int, ContentEntityLite>) : Int{
val remoteKeys = getRemoteKeyForLastItem(state)
private suspend fun getNextPageNumber() : Int{
val remoteKeys = getRemoteKeyForLastItem()
return remoteKeys?.nextKey ?: -1
}

private suspend fun getRemoteKeyForLastItem(state: PagingState<Int, ContentEntityLite>): ContentEntityLiteRemoteKey? {
return state.pages.lastOrNull() { it.data.isNotEmpty() }?.data
?.lastOrNull()
?.let { content ->
contentLiteRemoteKeyDao.remoteKeysContentId(content.id,type)
}
private suspend fun getRemoteKeyForLastItem(): ContentEntityLiteRemoteKey? {
return contentLiteDao.getLastContent(courseId, type)?.let { content ->
contentLiteRemoteKeyDao.remoteKeysContentId(content.id, type)
}
}

private suspend fun fetchCourseContents(page: Int = 1): ApiResponse<List<ContentEntityLite>> {
Expand Down