fix: Resolve pagination issue by fetching last content directly from the database#798
Open
PruthiviRaj27 wants to merge 1 commit intomasterfrom
Open
fix: Resolve pagination issue by fetching last content directly from the database#798PruthiviRaj27 wants to merge 1 commit intomasterfrom
PruthiviRaj27 wants to merge 1 commit intomasterfrom
Conversation
60060a4 to
10a426e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
PagingStatewas used to get the last item, which did not always return the correct content.LoadType.APPENDto fail since it couldn't determine the next page properly.Fix:
PagingStatelookup with a database querygetLastContentto fetch the last content item based oncontentOrder.getRemoteKeyForLastItemmethod to use this database query instead of relying onstate.pages.getPageNumberlogic by removing the unusedstateparameter.