Skip to content

Catch FileNotFoundException in AssetFileSystem.existsInternal #1815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swankjesse merged 1 commit into from
Jun 18, 2026
+7 −1
Merged

Catch FileNotFoundException in AssetFileSystem.existsInternal #1815

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion okio-assetfilesystem/src/main/kotlin/okio/assetfilesystem/AssetFileSystem.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,13 @@ private class AssetFileSystem(
// Both non-existent paths and paths to existing files return an empty array when listing.
// Determine if a path exists by checking if its name is present in the parent's list.
val parent = checkNotNull(parent) { "Path has no parent. Did you canonicalize? $this" }
val children = assets.list(parent.toAssetRelativePathString()).orEmpty()

val children = try {
assets.list(parent.toAssetRelativePathString()).orEmpty()
} catch (_: FileNotFoundException) {
emptyArray()
}

return name in children
}

Expand Down