Catch FileNotFoundException in AssetFileSystem.existsInternal#1815
Open
dellisd wants to merge 1 commit into
Open
Catch FileNotFoundException in AssetFileSystem.existsInternal#1815dellisd wants to merge 1 commit into
FileNotFoundException in AssetFileSystem.existsInternal#1815dellisd wants to merge 1 commit into
Conversation
JakeWharton
approved these changes
Jun 17, 2026
| val children = try { | ||
| assets.list(parent.toAssetRelativePathString()).orEmpty() | ||
| } catch (_: FileNotFoundException) { | ||
| return false |
Collaborator
There was a problem hiding this comment.
Suggested change
| return false | |
| emptyList() |
Doesn't really matter, but same behavior through a single return.
Under certain circumstances, the native asset manager implementation can throw a `FileNotFoundException` if the asset directory cannot be opened for listing (see https://android.googlesource.com/platform/frameworks/base/+/refs/heads/main/core/jni/android_util_AssetManager.cpp#475) This can, for example, cause `AssetFileSystem.exists()` to throw instead of returning `false` which is (arguably?) different from the behaviour of other `FileSystem` implementations.
dellisd
force-pushed
the
derekellis.2026-06-16.asset-catch
branch
from
26aca81 to
c2dacab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under certain circumstances, the native asset manager implementation can throw a
FileNotFoundExceptionif the asset directory cannot be opened for listing (see https://android.googlesource.com/platform/frameworks/base/+/refs/heads/main/core/jni/android_util_AssetManager.cpp#475)This can, for example, cause
AssetFileSystem.exists()to throw instead of returningfalsewhich is (arguably?) different from the behaviour of otherFileSystemimplementations.