Skip to content

Improve classpath entry lookup performance during jar creation and extraction #51787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wilkinsona merged 1 commit into from
Sep 17, 2026
+4 −4
Merged

Improve classpath entry lookup performance during jar creation and extraction #51787

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...rmode-tools/src/main/java/org/springframework/boot/jarmode/tools/IndexedJarStructure.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.nio.file.NoSuchFileException;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.LinkedHashSet;
import java.util.List;
import java.util.Set;
import java.util.function.UnaryOperator;
Expand Down Expand Up @@ -60,7 +60,7 @@ class IndexedJarStructure implements JarStructure {

private final String classesLocation;

private final List<String> classpathEntries;
private final Set<String> classpathEntries;

IndexedJarStructure(Manifest originalManifest, String indexFile) {
this.originalManifest = originalManifest;
Expand All @@ -74,12 +74,12 @@ private static String getLocation(Manifest manifest, String attribute) {
return (!location.endsWith("/")) ? location + "/" : location;
}

private static List<String> readIndexFile(String indexFile) {
private static Set<String> readIndexFile(String indexFile) {
String[] lines = Arrays.stream(indexFile.split("\n"))
.map((line) -> line.replace("\r", ""))
.filter(StringUtils::hasText)
.toArray(String[]::new);
List<String> classpathEntries = new ArrayList<>();
Set<String> classpathEntries = new LinkedHashSet<>();
for (String line : lines) {
Assert.state(line.startsWith("- "), "Classpath index file is malformed");
classpathEntries.add(line.substring(3, line.length() - 1));
Expand Down
Loading