Improve classpath entry lookup performance during jar creation and extraction - #51787
Merged
wilkinsona merged 1 commit intoSep 17, 2026
Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
added
type: task
wilkinsona
added
type: enhancement
wilkinsona
changed the title
Member
|
@noojung thanks for the PR. It was borderline whether I merged this as the benefit of the change vs the cost of merging it are in the balance. As with #51655, it's generally a better use of our time and yours to focus on contributions that address real-world problems or missing features that will have broad and noticeable benefit to as many of Boot's users as possible. |
See spring-projectsgh-51787 Signed-off-by: Hyunwoo Jung <hyunwoojung@kakao.com>
wilkinsona
force-pushed
the
improve-indexedjarstructure
branch
from
September 17, 2026 08:07
72fa3b1 to
fabfdd5
Compare
Contributor
Author
|
Thanks for the feedback. I understand your point, and I’ll keep this in mind for future contributions and try to focus on changes that address broader real-world needs. Thanks again for reviewing and merging the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IndexedJarStructure.resolve()is called for each archive entry during library extraction and application JAR creation. Each call checks classpath membership usingArrayList.contains(), which performs a linear scan.Replace the
ArrayListwith aLinkedHashSetto provide average constant-time membership checks while preserving classpath order in the launcher manifest.