Skip to content

MPT-19481 update skip markers and parameter type in tests#292

Merged
jentyk merged 1 commit intomainfrom
feat/MPT-19481
Apr 7, 2026
Merged

MPT-19481 update skip markers and parameter type in tests#292
jentyk merged 1 commit intomainfrom
feat/MPT-19481

Conversation

@jentyk
Copy link
Copy Markdown
Member

@jentyk jentyk commented Apr 7, 2026

Closes MPT-19481

  • tests/e2e/helpdesk/parameters/conftest.py: parameter fixture type changed from "String" to "SingleLineText"
  • tests/e2e/helpdesk/parameters/test_async_parameters.py: module skip reason updated to "Unskip after MPT-19967 fixed" (keeps pytest.mark.flaky)
  • tests/e2e/helpdesk/parameters/test_sync_parameters.py: removed module-level skip (retains pytest.mark.flaky), allowing tests to run

@jentyk jentyk requested a review from a team as a code owner April 7, 2026 15:24
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: da7fa775-5539-4984-8aa9-a627174e884b

📥 Commits

Reviewing files that changed from the base of the PR and between 8671c31 and fb93d43.

📒 Files selected for processing (3)
  • tests/e2e/helpdesk/parameters/conftest.py
  • tests/e2e/helpdesk/parameters/test_async_parameters.py
  • tests/e2e/helpdesk/parameters/test_sync_parameters.py
✅ Files skipped from review due to trivial changes (2)
  • tests/e2e/helpdesk/parameters/conftest.py
  • tests/e2e/helpdesk/parameters/test_async_parameters.py
🚧 Files skipped from review as they are similar to previous changes (1)
  • tests/e2e/helpdesk/parameters/test_sync_parameters.py

📝 Walkthrough

Walkthrough

Updated E2E helpdesk parameter tests: changed the fixture parameter "type" from "String" to "SingleLineText", removed the module-level skip from the sync test module, and updated the skip reason for the async test module.

Changes

Cohort / File(s) Summary
E2E Helpdesk Parameters tests
tests/e2e/helpdesk/parameters/conftest.py, tests/e2e/helpdesk/parameters/test_async_parameters.py, tests/e2e/helpdesk/parameters/test_sync_parameters.py
Changed fixture return value "type": "String""type": "SingleLineText" in conftest.py; updated module-level pytestmark in test_async_parameters.py to keep skip but change reason to "Unskip after MPT-19967 fixed"; removed the skip mark from test_sync_parameters.py (leaving pytest.mark.flaky).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • mpt-api-python-client#244: Introduced the test fixtures and test modules in this same E2E helpdesk parameter test directory that are being modified here.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key in the required format MPT-XXXX at the beginning: MPT-19481.
Test Coverage Required ✅ Passed The PR only modifies test files within the tests/ folder (conftest.py and two test modules). No code files outside tests/ are modified.
Single Commit Required ✅ Passed The PR contains exactly one commit (fb93d43) not yet in the main branch, satisfying the single commit requirement.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 7, 2026

@jentyk jentyk merged commit 3f49d0d into main Apr 7, 2026
4 checks passed
@jentyk jentyk deleted the feat/MPT-19481 branch April 7, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants