Skip to content

MPT-19480 update parameter type and skip markers in tests#294

Merged
jentyk merged 1 commit intomainfrom
feat/MPT-19480
Apr 7, 2026
Merged

MPT-19480 update parameter type and skip markers in tests#294
jentyk merged 1 commit intomainfrom
feat/MPT-19480

Conversation

@jentyk
Copy link
Copy Markdown
Member

@jentyk jentyk commented Apr 7, 2026

Closes MPT-19480

  • Change parameter fixture type from "String" to "SingleLineText" in E2E helpdesk parameter tests (tests/e2e/helpdesk/parameter_groups/parameters/conftest.py)
  • Update module-level skip reason to "Unskip after MPT-19967 fixed" across E2E parameter-related test suites:
    • tests/e2e/helpdesk/parameters/test_sync_parameters.py
    • tests/e2e/helpdesk/parameters/test_async_parameters.py
    • tests/e2e/helpdesk/parameter_groups/parameters/test_sync_parameters.py
    • tests/e2e/helpdesk/parameter_groups/parameters/test_async_parameters.py
    • tests/e2e/helpdesk/parameter_groups/test_sync_parameter_groups.py
    • tests/e2e/helpdesk/parameter_groups/test_async_parameter_groups.py

@jentyk jentyk requested a review from a team as a code owner April 7, 2026 16:02
@jentyk jentyk requested review from alephsur and d3rky April 7, 2026 16:02
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7528b1a7-1b34-4b80-b610-dba8157a9596

📥 Commits

Reviewing files that changed from the base of the PR and between 4b815f6 and 1b693c7.

📒 Files selected for processing (5)
  • tests/e2e/helpdesk/parameter_groups/parameters/conftest.py
  • tests/e2e/helpdesk/parameter_groups/parameters/test_async_parameters.py
  • tests/e2e/helpdesk/parameter_groups/parameters/test_sync_parameters.py
  • tests/e2e/helpdesk/parameter_groups/test_async_parameter_groups.py
  • tests/e2e/helpdesk/parameter_groups/test_sync_parameter_groups.py
✅ Files skipped from review due to trivial changes (5)
  • tests/e2e/helpdesk/parameter_groups/parameters/conftest.py
  • tests/e2e/helpdesk/parameter_groups/test_sync_parameter_groups.py
  • tests/e2e/helpdesk/parameter_groups/test_async_parameter_groups.py
  • tests/e2e/helpdesk/parameter_groups/parameters/test_async_parameters.py
  • tests/e2e/helpdesk/parameter_groups/parameters/test_sync_parameters.py

📝 Walkthrough

Walkthrough

Changed a helpdesk parameter fixture's "type" from "String" to "SingleLineText" and updated module-level pytest skip reason strings from "Skipped per MPT-18373 request" to "Unskip after MPT-19967 fixed" across four E2E test modules.

Changes

Cohort / File(s) Summary
Fixture Data
tests/e2e/helpdesk/parameter_groups/parameters/conftest.py
Updated parameter fixture parameter_data["type"] from "String" to "SingleLineText", affecting fixtures that consume it.
Test Skip Reasons
tests/e2e/helpdesk/parameter_groups/parameters/test_async_parameters.py, tests/e2e/helpdesk/parameter_groups/parameters/test_sync_parameters.py, tests/e2e/helpdesk/parameter_groups/test_async_parameter_groups.py, tests/e2e/helpdesk/parameter_groups/test_sync_parameter_groups.py
Replaced module-level pytest.mark.skip reason "Skipped per MPT-18373 request" with "Unskip after MPT-19967 fixed" while retaining pytest.mark.flaky markers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed PR title contains exactly one Jira issue key (MPT-19480) in the required MPT-XXXX format at the beginning.
Test Coverage Required ✅ Passed All 5 modified files are test files located in tests/ folder; no code files outside tests/ were modified.
Single Commit Required ✅ Passed The PR contains exactly one commit (1b693c7: 'test(helpdesk): update parameter type and skip markers in tests'). The git log shows a single commit between main and the PR branch.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 7, 2026

@jentyk jentyk merged commit f543c53 into main Apr 7, 2026
4 checks passed
@jentyk jentyk deleted the feat/MPT-19480 branch April 7, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants