Skip to content

Backport release/v6.4: fixed ValidatorInfo json encoding#3115

Merged
pompon0 merged 1 commit intorelease/v6.4from
backport-3114-to-release/v6.4
Mar 25, 2026
Merged

Backport release/v6.4: fixed ValidatorInfo json encoding#3115
pompon0 merged 1 commit intorelease/v6.4from
backport-3114-to-release/v6.4

Conversation

@seidroid
Copy link

@seidroid seidroid bot commented Mar 24, 2026

Backport of #3114 to release/v6.4.

There were 2 issues:
* for backward compatibility with CosmJS, PubKey needs to be a 0 key in
case of non-validator node.
* decoding was broken altogether, because it always returned the zero
value of ValidatorInfo

(cherry picked from commit be7fb02)
@github-actions
Copy link

github-actions bot commented Mar 24, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 24, 2026, 9:02 PM

@github-actions
Copy link

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 24, 2026, 7:31 PM

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.40%. Comparing base (8adc72e) to head (fa411df).
⚠️ Report is 1 commits behind head on release/v6.4.

Files with missing lines Patch % Lines
sei-tendermint/rpc/coretypes/responses.go 60.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           release/v6.4    #3115   +/-   ##
=============================================
  Coverage         58.40%   58.40%           
=============================================
  Files              2088     2088           
  Lines            172130   172133    +3     
=============================================
+ Hits             100538   100542    +4     
+ Misses            62637    62635    -2     
- Partials           8955     8956    +1     
Flag Coverage Δ
sei-chain-pr 76.11% <60.00%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/rpc/coretypes/responses.go 78.12% <60.00%> (+1.78%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 enabled auto-merge (squash) March 24, 2026 21:01
@pompon0 pompon0 requested review from masih and philipsu522 March 24, 2026 21:02
@pompon0 pompon0 merged commit 3b37866 into release/v6.4 Mar 25, 2026
41 of 43 checks passed
@pompon0 pompon0 deleted the backport-3114-to-release/v6.4 branch March 25, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants