Skip to content

fixed ValidatorInfo json encoding#3114

Merged
pompon0 merged 3 commits intomainfrom
gprusak-cosmjs
Mar 24, 2026
Merged

fixed ValidatorInfo json encoding#3114
pompon0 merged 3 commits intomainfrom
gprusak-cosmjs

Conversation

@pompon0
Copy link
Copy Markdown
Contributor

@pompon0 pompon0 commented Mar 24, 2026

There were 2 issues:

  • for backward compatibility with CosmJS, PubKey needs to be a 0 key in case of non-validator node.
  • decoding was broken altogether, because it always returned the zero value of ValidatorInfo

@pompon0 pompon0 requested review from masih and philipsu522 March 24, 2026 16:19
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2026

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 24, 2026, 6:36 PM

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026

Codecov Report

❌ Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.56%. Comparing base (1141939) to head (914e37a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
sei-tendermint/rpc/coretypes/responses.go 60.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3114      +/-   ##
==========================================
- Coverage   58.62%   58.56%   -0.07%     
==========================================
  Files        2099     2098       -1     
  Lines      173751   173448     -303     
==========================================
- Hits       101867   101578     -289     
+ Misses      62816    62813       -3     
+ Partials     9068     9057      -11     
Flag Coverage Δ
sei-chain-pr 76.11% <60.00%> (?)
sei-db 70.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/rpc/coretypes/responses.go 78.12% <60.00%> (+1.78%) ⬆️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pompon0 pompon0 enabled auto-merge March 24, 2026 18:35
@pompon0 pompon0 added this pull request to the merge queue Mar 24, 2026
Merged via the queue into main with commit be7fb02 Mar 24, 2026
39 of 40 checks passed
@pompon0 pompon0 deleted the gprusak-cosmjs branch March 24, 2026 19:30
github-actions bot pushed a commit that referenced this pull request Mar 24, 2026
There were 2 issues:
* for backward compatibility with CosmJS, PubKey needs to be a 0 key in
case of non-validator node.
* decoding was broken altogether, because it always returned the zero
value of ValidatorInfo

(cherry picked from commit be7fb02)
@seidroid
Copy link
Copy Markdown

seidroid bot commented Mar 24, 2026

Successfully created backport PR for release/v6.4:

pompon0 added a commit that referenced this pull request Mar 25, 2026
Backport of #3114 to `release/v6.4`.

Co-authored-by: Grzegorz Prusak <pompon.pompon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants