Skip to content

fix(config): refine error handling of Cfg::notify_release() #4973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rami3l merged 1 commit into from
Jul 25, 2026
+7 −3
Merged

fix(config): refine error handling of Cfg::notify_release() #4973

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/config.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1021,9 +1021,13 @@ impl<'a> Cfg<'a> {

let default_host = self.default_host_tuple()?;
let stable_desc = PartialToolchainDesc::from_str("stable")?.resolve(&default_host)?;
let distributable = DistributableToolchain::new(self, stable_desc)
.map_err(|e| anyhow!("stable toolchain unavailable: {e}"))?;
let release_date_str = match distributable.get_manifestation() {
let stable = match DistributableToolchain::new(self, stable_desc) {
Ok(stable) => stable,
// If the `stable` toolchain is not installed, we don't notify the user.
Err(RustupError::ToolchainNotInstalled { .. }) => return Ok(()),
Err(e) => return Err(anyhow!(e).context("while looking for local stable toolchain")),
};
let release_date_str = match stable.get_manifestation() {
Ok(manifestation) => match manifestation.load_manifest() {
Ok(Some(manifest)) => manifest.date,
Ok(None) | Err(_) => FALLBACK_RELEASE_DATE.to_owned(),
Expand Down
Loading