Skip to content

fix(config): refine error handling of Cfg::notify_release() - #4973

Merged
rami3l merged 1 commit into
rust-lang:mainfrom
rami3l:fix/notify-release-no-stable
Jul 25, 2026
Merged

fix(config): refine error handling of Cfg::notify_release()#4973
rami3l merged 1 commit into
rust-lang:mainfrom
rami3l:fix/notify-release-no-stable

Conversation

@rami3l

@rami3l rami3l commented Jul 25, 2026

Copy link
Copy Markdown
Member

When notifying a release, we should not assume that the stable toolchain is already installed, otherwise we would spam the user with those warnings:

warn: could not check if there is a new Rust release: stable toolchain unavailable: toolchain 'stable-aarch64-apple-darwin' is not installed
help: run `rustup toolchain install stable-aarch64-apple-darwin` to install it

This PR makes this warning disappear when stable is not installed.

@rami3l
rami3l requested a review from FranciscoTGouveia July 25, 2026 07:40
@rami3l
rami3l marked this pull request as ready for review July 25, 2026 07:41

@FranciscoTGouveia FranciscoTGouveia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this.

View changes since this review

Comment thread src/config.rs Outdated
Co-authored-by: Francisco Gouveia <francisco.t.gouveia@tecnico.ulisboa.pt>
@rami3l
rami3l force-pushed the fix/notify-release-no-stable branch from ce74fcc to fe8c7e3 Compare July 25, 2026 08:58
@rami3l
rami3l enabled auto-merge July 25, 2026 08:59
@rami3l
rami3l added this pull request to the merge queue Jul 25, 2026
Merged via the queue into rust-lang:main with commit 6b51175 Jul 25, 2026
31 checks passed
@rami3l
rami3l deleted the fix/notify-release-no-stable branch July 25, 2026 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants