Enhance integration testing guide with WaitForTopics feature - #7076
Open
LastStarDust wants to merge 1 commit into
Open
Enhance integration testing guide with WaitForTopics feature#7076LastStarDust wants to merge 1 commit into
LastStarDust wants to merge 1 commit into
Conversation
Updated integration testing documentation to include new utilities and clarify test setup. Signed-off-by: Giorgio Pintaudi <pintaudi@axelspace.com>
Member
|
@Shru can you take a look at this please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated integration testing documentation to use the new
WaitForTopicsfeatureDescription
This PR addresses issue #5249 by updating the integration testing tutorial to showcase the
WaitForTopicsutility fromlaunch_testing_ros.Replaced manual subscriber logic with
WaitForTopics: The original example used manualrclpy.create_subscription()andspin_once()loops. The updated tutorial demonstrates theWaitForTopicsapproach, which is cleaner and serves as a better learning example for users.No more magic numbers: Removed the problematic 0.5-second
TimerActionbeforeReadyToTest(). Tests now use event-driven waiting viaPublisherEventCallbacksinstead of "sleep" hacks. Moreover, it checks for specific velocity conditions.Added trigger callback example: Included an example of the
triggerfunction, demonstrating how to publish control messages and verify robot response using the newtriggerparameter ofWaitForTopics. This was already proposed in the original document.Did you use Generative AI?
Not for the source code and only partially for the text. But I double-checked each line of text.
Additional Information
All code examples have been tested in this sample repository.
I added a new section on Python-only package setup.