__build__.py windows compat + make comfy exports#609
Open
sfinktah wants to merge 1 commit intorgthree:mainfrom
Open
__build__.py windows compat + make comfy exports#609sfinktah wants to merge 1 commit intorgthree:mainfrom
sfinktah wants to merge 1 commit intorgthree:mainfrom
Conversation
Contributor
Author
|
If you just want the functionality of adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were the changes necessary to get a Windows based build to work. There are some [possibly] superfluous checks that I attempted to strip out after, but that reintroduced a bug that caused paths in the .js import statements to look like
../../../../../../../../../this.js, so I just left it in.The only functional difference is that this build includes an
-Eoption which modifies comfyui/frontend'sindex.d.tsfile to force all declarations to be exported.I can't see how you could have ever sucessfully run it without performing that step manually anyway, but no doubt you will surprise me somehow.
This is submitted more as an explanation in detail, rather than any expectation of being merged -- though I have full confidence it will not be harmful if you do decide to merge it.
Testing
The output of
npm run buildwas identical to what was already in the repo, excepting 6.cssfiles, which differed only in the line endings (unix vs windows).