build.py: updated path normalization for .js files [windows]#613
Open
sfinktah wants to merge 1 commit intorgthree:mainfrom
Open
build.py: updated path normalization for .js files [windows]#613sfinktah wants to merge 1 commit intorgthree:mainfrom
.js files [windows]#613sfinktah wants to merge 1 commit intorgthree:mainfrom
Conversation
… windows builds)
Contributor
Author
|
@rgthree any change of expiditing this one? it's an absolute pain to have to patch manually for every PR. ... of course, you could probably do with less PRs. :) |
r-vage
added a commit
to r-vage/rgthree-comfy
that referenced
this pull request
Feb 9, 2026
- PR rgthree#613: Fix __build__.py path handling for cross-platform compatibility (use os.path.relpath) - PR rgthree#465: Fix README.md typo (custom_modules → custom_nodes) - PR rgthree#264: Add shift key support to keep LoRA menu open + fix callback return propagation - PR rgthree#267: Add context menu option to fetch info for all LoRAs at once
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the one-line fix for the issue with building on Windows. The one that created
../../../../../../../../app.jspaths.This avoids the excessive changes in #609.
The declarations in comfy/frontend do still need to be made exportable, but there is probably a more appropriate place to deal with that.