hub-client: UI/UX Phase 5 review adjustments (fullscreen fix, sidebar toggle, smallest header) - #625
Merged
Merged
Conversation
The Phase 5.5 split-collapse rule hid .preview-pane in view-mode-both below 700px — including when the pane was in fullscreen-preview mode, leaving a blank pane (the editor pane unmounts in fullscreen). Exclude .fullscreen from the collapse. Regression cover: new #/dev/editor-shell-fullscreen harness route + specs at 700px and 320px (watched them fail before the fix).
…e 5 review, bd-tfsdmytf) Design-review adjustment from the Phase 5 gate: the sidebar toggle was drawer-only (<=900px) and easy to miss. It is now permanent header chrome at every width — above 900px it hides/shows the static sidebar (VS Code style), at <=900px it opens/closes the overlay drawer as before. The two modes keep separate state: hiding the static sidebar does not open the drawer on a narrow resize (spec-pinned). The button reads as sidebar chrome, not a title-bar action: muted grey at rest, faint sidebar-tinted background while the sidebar is open. Specs: updated the 1280px counter-check, added hide/restore at 1280px and the cross-breakpoint state test (watched all three fail first). Regenerated darwin captures: minimal-header (new button), editor-shell and drawer (grey toggle). No linux baseline impact beyond what the recreate workflow already regenerated — CI will add the new captures.
…ase 5 review, bd-tfsdmytf) Design-review round 2 on the narrow-viewport header: - At <=700px the view-mode segmented control is hidden (split view is collapsed there anyway; the Preview pill covers editor<->preview) and Share + Preview stay inline — the kebab overflow menu is retired (MinimalHeader, specs, and the now-unreachable split-disable logic in ViewToggleControl all cleaned up). - The sidebar toggle is now unmistakably sidebar chrome: a filled chip in the sidebar's own background tint + border, grey in both states, deepening to the sidebar's content tint while open. The switch-project button takes the teal accent instead — it is the one header action that exits to another view. - Harness: the header route stubs the drawer id so the toggle's aria-controls isn't a dangling reference (axe aria-valid-attr-value). - Specs: smallest-header composition at 700/320px, toggle chip distinction in both states (computed-style), teal switch assertion; split-collapse spec updated for the hidden toggle. axe baseline regenerated (an earlier interrupted write left it partial).
Member
Author
|
@cderv fyi this PR gives you the sidebar toggle you wanted. |
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
shikokuchuo
added a commit
that referenced
this pull request
Aug 27, 2026
A recreate-all-snapshots dispatch on hub-client-uiux-phase5-review (20:37) raced the merge of PR #625 (20:50): the run's push step recreated the deleted branch and committed the regenerated baselines there 18 minutes post-merge, so main has the Phase 5 UI with stale baselines. The mismatch fails the visual suite on main and every open PR (the --update-snapshots=missing retry only adds NEW baselines). Cherry-picks the 13 regenerated linux snapshots (minimal-header, editor-shell x4 widths, sidebar-drawer, projects-home-empty) onto main. (cherry picked from commit f120b2e) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #622 (merged before the design review finished): the adjustments from your review feedback.
Before → after
Screenshots (light theme)
Header at 1280 px
Editor at 700 px
Editor at 320 px
Tests
lint:css+ typecheck: clean.CI note
The header captures changed, so the linux baselines need one more regeneration: dispatch
hub-client-e2e.ymlwithrecreate-all-snapshots=trueon this branch.Images load from the
phase5-review-assetsbranch (same as #622).