hub-client: regenerate Phase 5 linux visual baselines (orphaned by post-merge recreate run) - #627
Merged
Merged
Conversation
A recreate-all-snapshots dispatch on hub-client-uiux-phase5-review (20:37) raced the merge of PR #625 (20:50): the run's push step recreated the deleted branch and committed the regenerated baselines there 18 minutes post-merge, so main has the Phase 5 UI with stale baselines. The mismatch fails the visual suite on main and every open PR (the --update-snapshots=missing retry only adds NEW baselines). Cherry-picks the 13 regenerated linux snapshots (minimal-header, editor-shell x4 widths, sidebar-drawer, projects-home-empty) onto main. (cherry picked from commit f120b2e)
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A
recreate-all-snapshotsdispatch onhub-client-uiux-phase5-review(run 33114255766, started 20:37) raced the merge of #625 (merged 20:50). The run's baseline-commit step pushed at 21:08 — 18 minutes after the merge — recreating the deleted branch as a zombie and landing the regenerated baselines there instead of onmain.Result:
mainhas the Phase 5 UI with stale baselines. The 13 files are mismatches on existing baselines, not missing files, so the visual suite's--update-snapshots=missingretry cannot self-heal — the in-flightmainE2E run and every open PR (including #626) fail the visual step until this lands.What
Cherry-picks
f120b2e0f(the bot's regenerated baselines commit) ontomain: 13 linux snapshots for the Phase 5 review surfaces —minimal-header,editor-shellat 320/480/700/900,sidebar-drawer-800,projects-home-empty.Verification
The PR's own visual E2E run is the verification: it should go green where
mainis red. No code changes.Unblocks #626. The zombie
hub-client-uiux-phase5-reviewbranch is deleted as part of this cleanup.