Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ name: Test Suite

on:
push:
branches: ["main"]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: This PR removes branches: ["main"] from the push trigger, which silently widens CI to run on every branch push — not just pushes to main. That's a meaningful behavioral change unrelated to the stated Python 3.15 support goal. If this was intentional, it should be called out in the PR description. Otherwise, keep the original branches: ["main"] filter. Additionally, running on both push (any branch) and pull_request creates duplicate CI runs when a PR is open, consuming extra runner minutes.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/main.yml, line 5:

<comment>This PR removes `branches: ["main"]` from the push trigger, which silently widens CI to run on every branch push — not just pushes to main. That's a meaningful behavioral change unrelated to the stated Python 3.15 support goal. If this was intentional, it should be called out in the PR description. Otherwise, keep the original `branches: ["main"]` filter. Additionally, running on both `push` (any branch) and `pull_request` creates duplicate CI runs when a PR is open, consuming extra runner minutes.</comment>

<file context>
@@ -2,7 +2,6 @@ name: Test Suite
 on:
   push:
-    branches: ["main"]
   pull_request:
     branches: ["main", "version-*"]
 
</file context>

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to allow testing feature branches on forks, rather than having to develop in main. I want to make sure the CI actually passes before opening a PR and wasting the time of upstream maintainers; it could have been that some dependency is not yet ready for 3.15 and won't be for several months.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't slip, I noticed. All good. 🙏

pull_request:
branches: ["main", "version-*"]

Expand All @@ -16,7 +15,7 @@ jobs:

strategy:
matrix:
python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"]
python-version: ["3.10", "3.11", "3.12", "3.13", "3.14", "3.15"]

steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
Expand Down
1 change: 1 addition & 0 deletions src/httpcore2/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ classifiers = [
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
"Programming Language :: Python :: 3.15",
"Topic :: Internet :: WWW/HTTP",
]
dependencies = ["truststore>=0.10", "h11>=0.16"]
Expand Down
1 change: 1 addition & 0 deletions src/httpx2/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ classifiers = [
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
"Programming Language :: Python :: 3.14",
"Programming Language :: Python :: 3.15",
"Topic :: Internet :: WWW/HTTP",
]
dynamic = ["readme", "version", "dependencies"]
Expand Down
Loading
Loading