Add support for Python 3.15 - #1090
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
There was a problem hiding this comment.
1 issue found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".github/workflows/main.yml">
<violation number="1" location=".github/workflows/main.yml:5">
P2: This PR removes `branches: ["main"]` from the push trigger, which silently widens CI to run on every branch push — not just pushes to main. That's a meaningful behavioral change unrelated to the stated Python 3.15 support goal. If this was intentional, it should be called out in the PR description. Otherwise, keep the original `branches: ["main"]` filter. Additionally, running on both `push` (any branch) and `pull_request` creates duplicate CI runs when a PR is open, consuming extra runner minutes.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
|
|
||
| on: | ||
| push: | ||
| branches: ["main"] |
There was a problem hiding this comment.
P2: This PR removes branches: ["main"] from the push trigger, which silently widens CI to run on every branch push — not just pushes to main. That's a meaningful behavioral change unrelated to the stated Python 3.15 support goal. If this was intentional, it should be called out in the PR description. Otherwise, keep the original branches: ["main"] filter. Additionally, running on both push (any branch) and pull_request creates duplicate CI runs when a PR is open, consuming extra runner minutes.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/main.yml, line 5:
<comment>This PR removes `branches: ["main"]` from the push trigger, which silently widens CI to run on every branch push — not just pushes to main. That's a meaningful behavioral change unrelated to the stated Python 3.15 support goal. If this was intentional, it should be called out in the PR description. Otherwise, keep the original `branches: ["main"]` filter. Additionally, running on both `push` (any branch) and `pull_request` creates duplicate CI runs when a PR is open, consuming extra runner minutes.</comment>
<file context>
@@ -2,7 +2,6 @@ name: Test Suite
on:
push:
- branches: ["main"]
pull_request:
branches: ["main", "version-*"]
</file context>
There was a problem hiding this comment.
This is to allow testing feature branches on forks, rather than having to develop in main. I want to make sure the CI actually passes before opening a PR and wasting the time of upstream maintainers; it could have been that some dependency is not yet ready for 3.15 and won't be for several months.
There was a problem hiding this comment.
It didn't slip, I noticed. All good. 🙏
Summary
Add support for Python 3.15: test on CI, update lock file to include 3.15 wheels for dependencies, add Trove classifier.
The Python 3.15 beta is out. 🚀
The 3.15 release manager (👋 hi, that's me!) said:
Checklist