Conversation
Found running polymorph-webrtc-datachannels' driver-ct loopback suite under the upstreamed copy of this port (the #19 run, delivered as their PR #149): PeerConnection.close() closed only the native channels, so a post-close send could still observe readyState "open" inside node-datachannel's asynchronous transition window — their solo/post-close-send case raced its 1000-send bound against the 1 s close-drain and failed intermittently under the callback ABI's await cadence (JSPI's slower awaits hide the same latent race in their jco-impl reference). close() now closes the owned channels through their DataChannel wrappers, whose local-close flag is the synchronous gate the WIT contract's "observed locally at once" requires — the same discipline DataChannel.close() already applies. Regression test added; docs: consumers.md webrtc row gains the conformance-matrix gate. Gate: just test-webrtc (10/10).
lann
added a commit
that referenced
this pull request
Aug 10, 2026
The runner-networking theory is disproven and the actual defects are fixed (#36, #37, root-caused via polymorph-webrtc-datachannels#149's probe matrix): the unit-test timeouts were a candidate-buffering race in the tests' own connectPair helper, and the exit-path SIGSEGV was the addon's thread joins racing isolate teardown after cleanup(). Both fixes are runner-validated (deno task test exits 0 on ubuntu-latest in the consumer repo, and their Conformance matrix job runs the same suite class green). Drop the tolerated wrapper and the stale rationale comments. Gate: just test-webrtc.
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found running polymorph-webrtc-datachannels' driver-ct loopback suite under the upstreamed copy of this port (the #19 run, delivered as polymorph-webrtc-datachannels#149):
PeerConnection.close()closed only the native channels, so a post-closesendcould still observereadyState === "open"inside node-datachannel's asynchronous transition window — theirsolo/post-close-sendcase races its 1000-send bound against the 1 s close-drain and failed intermittently under the callback ABI's await cadence (JSPI's slower awaits hide the same latent race in their jco-impl reference, noted in their PR).close()now closes the owned channels through theirDataChannelwrappers, whose local-close flag is the synchronous gate the WIT contract's "observed locally at once" requires — the same disciplineDataChannel.close()already applies to its own resource. Regression test added (first post-close send failsclosed, on the locally created and the incoming channel alike).Also: docs/consumers.md's webrtc row gains the conformance-matrix gate reference.
Gate:
just test-webrtc— 10/10 on the dev box (the authoritative environment per #21).