CI: test-webrtc becomes a required core step (#21 closed) - #38
Merged
Conversation
The runner-networking theory is disproven and the actual defects are fixed (#36, #37, root-caused via polymorph-webrtc-datachannels#149's probe matrix): the unit-test timeouts were a candidate-buffering race in the tests' own connectPair helper, and the exit-path SIGSEGV was the addon's thread joins racing isolate teardown after cleanup(). Both fixes are runner-validated (deno task test exits 0 on ubuntu-latest in the consumer repo, and their Conformance matrix job runs the same suite class green). Drop the tolerated wrapper and the stale rationale comments. Gate: just test-webrtc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the #21 root causes fixed and runner-validated (#36 latch, #37 test race + teardown settle; evidence in polymorph-webrtc-datachannels#149's probe runs), the webrtc unit suite no longer needs tolerance on runners:
gha::corerunstest-webrtcas a required step, and the stale runner-networking rationale comments go away. The webkit lane keeps_step-tolerated(its only remaining user).Closes #21.