Skip to content

Make server e2e readiness timeout configurable #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
quartzjer wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make server e2e readiness timeout configurable #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ jobs:
# PARAKEET_SERVER_E2E=1 flips the test from skip (77) to a real run.
env:
PARAKEET_SERVER_E2E: "1"
# First-run model download speed varies on hosted runners; the job
# timeout remains the outer cap.
PARAKEET_SERVER_E2E_READY_TIMEOUT: "600"
run: ctest --test-dir build --output-on-failure -R '^server_e2e$'

# -------------------------------------------------------------------------
Expand Down
11 changes: 8 additions & 3 deletions tests/server_e2e.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ fi
SERVER="${1:?need path to parakeet-server}"
FIXTURE="tests/fixtures/speech.wav"
PORT="${PARAKEET_SERVER_E2E_PORT:-18080}"
READY_TIMEOUT="${PARAKEET_SERVER_E2E_READY_TIMEOUT:-180}"
CACHE="$(mktemp -d)"
EXPECT="turning away her"

Expand All @@ -24,18 +25,22 @@ trap cleanup EXIT

command -v curl >/dev/null 2>&1 || { echo "server_e2e: curl required"; exit 1; }
[ -f "$FIXTURE" ] || { echo "server_e2e: missing $FIXTURE"; exit 1; }
case "$READY_TIMEOUT" in
''|*[!0-9]*) echo "server_e2e: PARAKEET_SERVER_E2E_READY_TIMEOUT must be seconds"; exit 1 ;;
esac
[ "$READY_TIMEOUT" -gt 0 ] || { echo "server_e2e: PARAKEET_SERVER_E2E_READY_TIMEOUT must be > 0"; exit 1; }

"$SERVER" --model tdt_ctc-110m-q4_k --port "$PORT" --cache-dir "$CACHE" &
SRV=$!

# Wait up to 180s for /health (covers the model download on first run).
# Wait for /health. The server binds only after first-run model download + load.
ready=0
for _ in $(seq 1 180); do
for _ in $(seq 1 "$READY_TIMEOUT"); do
if curl -fs "http://127.0.0.1:$PORT/health" >/dev/null 2>&1; then ready=1; break; fi
kill -0 "$SRV" 2>/dev/null || { echo "server_e2e: server exited early"; exit 1; }
sleep 1
done
[ "$ready" = "1" ] || { echo "server_e2e: server not ready"; exit 1; }
[ "$ready" = "1" ] || { echo "server_e2e: server not ready after ${READY_TIMEOUT}s"; exit 1; }

base="http://127.0.0.1:$PORT/v1/audio/transcriptions"
fail=0
Expand Down
Loading