Make server e2e readiness timeout configurable#43
Open
quartzjer wants to merge 1 commit into
Open
Conversation
Assisted-by: Codex:gpt-5 [Codex]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PARAKEET_SERVER_E2E_READY_TIMEOUTtotests/server_e2e.shWhy
PR #41 hit a
server-e2efailure where the server was still downloading the first-runtdt_ctc-110m-q4_k.ggufmodel at the previous 180s readiness deadline. The log showed the 125 MB download around 82% whenserver_e2e: server not readyfired, then finishing seconds later. Since/healthonly becomes available after model download and load, the readiness wait needs to allow hosted-runner network variance.Validation
bash -n tests/server_e2e.shtests/server_e2e.sh; test $? -eq 77PARAKEET_SERVER_E2E=1 PARAKEET_SERVER_E2E_READY_TIMEOUT=bogus tests/server_e2e.sh /bin/true; test $? -eq 1PARAKEET_SERVER_E2E=1 PARAKEET_SERVER_E2E_READY_TIMEOUT=0 tests/server_e2e.sh /bin/true; test $? -eq 1git diff --check