You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@tombch and I were looking into the exposed ORM and I realized we have a dependency for a different ORM hibernate that appears unused in the code - I now checked that the preview is healthy, so I would remove the dependency.
resolves #
Screenshot
PR Checklist
All necessary documentation has been adapted.
The implemented feature is covered by appropriate, automated tests.
Any manual testing that has been done is documented (i.e. what exactly was tested?)
anna-parker
changed the title
feat(backend): get rid of unused hibernate dependency - we do not use…
feat(backend): get rid of unused hibernate dependency
Apr 16, 2026
The change removes implementation "org.hibernate.validator:hibernate-validator" from build.gradle.
Verdict: LGTM with one minor note.
The explicit declaration is redundant — gradle.lockfile still contains org.hibernate.validator:hibernate-validator:8.0.3.Final across all configurations, confirming it remains on the classpath via a transitive dependency (likely from springdoc-openapi-starter-webmvc-ui or another Spring Boot starter). No functionality is broken.
One small thing worth noting: the PR description calls this "unused", but hibernate-validator is the runtime implementation of the Jakarta Bean Validation API. The backend does use validation annotations (@Valid, @Max, custom ConstraintValidator implementations in SubmissionController, Organism.kt, etc.) that depend on it at runtime. The explicit declaration is redundant (not unused). A minor wording distinction, but it could mislead a future reader into thinking the validation feature itself isn't needed.
No tests or documentation changes are needed for a dependency declaration cleanup like this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backendrelated to the loculus backend componentdependenciesPull requests that update a dependency filejavaPull requests that update Java codepreviewTriggers a deployment to argocd
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tombch and I were looking into the exposed ORM and I realized we have a dependency for a different ORM hibernate that appears unused in the code - I now checked that the preview is healthy, so I would remove the dependency.
resolves #
Screenshot
PR Checklist
🚀 Preview: https://remove-hibernate.loculus.org