Fix Keycloak database service naming for ephemeral dev deployments#6216
Fix Keycloak database service naming for ephemeral dev deployments#6216theosanderson wants to merge 3 commits intomainfrom
Conversation
…event stale DB connections When using the ephemeral development keycloak database, the service name now includes the docker tag (e.g. loculus-keycloak-database-service-commit-abc123). This ensures keycloak cannot connect to an old database instance during redeployments - it will only resolve DNS once the new database pod with the matching service selector is running. https://claude.ai/code/session_01FjiKZfHS8w53Anu9Krk4hi
claude
bot
added
deployment
|
Claude finished @anna-parker's task in 2m 3s —— View job Code Review
The fix is correct in its core logic — adding the conditional One concern raised via inline comment: the selector in |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Co-authored-by: Anna (Anya) Parker <50943381+anna-parker@users.noreply.github.com>
| - name: KC_DB | ||
| value: postgres | ||
| - name: KC_DB_URL_HOST | ||
| {{- if .Values.runDevelopmentKeycloakDatabase }} |
There was a problem hiding this comment.
Im not sure I understand this change - @theosanderson could you perhaps explain it to me?
There was a problem hiding this comment.
If running the development keycloak DB this change would use the template for the service name
There was a problem hiding this comment.
(I'm not sure which bit you are asking about - Slack may be better?)
3 participants
PR Checklist
🚀 Preview: https://claude-review-pr-discussi.loculus.org