feat(website): add tooltips for metadata field descriptions to search ui #6209
feat(website): add tooltips for metadata field descriptions to search ui #6209
Conversation
|
Claude finished @tombch's task in 1m 35s —— View job Code ReviewOverall this is a clean, well-scoped feature. The approach of attaching definitions to the Bug — YAML injection risk (inline): Bug — invalid Tailwind class (inline): Nit — redundant condition (inline): The inner Design note — Testing: No automated tests cover the |
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
| rangeOverlapSearch: | ||
| rangeName: sampleCollectionDateRange | ||
| rangeDisplayName: Collection date | ||
| rangeDefinitionField: sampleCollectionDate |
There was a problem hiding this comment.
Is there a reason why just adding a definition field to name: sampleCollectionDateRangeUpper and name: sampleCollectionDateRangeLower isnt enough? I cant immedietly see why we need a new field rangeDefinitionField, but I might be missing sth
|
|
||
| {{- define "loculus.standardWebsiteMetadata" }} | ||
| - type: {{ .type | default "string" | quote }} | ||
| {{- if .definition }} |
There was a problem hiding this comment.
ah could you make an issue detailing how we should maybe refactor the helm template to not duplicate inputFields and metadata and have the website produce inputFields from metadata and filter out input only fields when sending the metadata to the backend and silo/lapis?
There was a problem hiding this comment.
heyhey - think this is overall a great improvement, but I think we dont need a new rangeDefinitionField for this (I might be wrong though)
Update: ah! it would also be cool to test this on a PPX preview to see if we need to add description to some internal metadata fields still :-)
Adds tooltips for metadata field definitions in search, column and download field selector modals. This could be quite a convenient place (imo) to provide additional information on processed metadata fields but open to alternate suggestions!
Screenshot
PR Checklist
🚀 Preview: https://search-field-tooltips.loculus.org