feat: post-logout redirect override + keep LoQE engine warm across previews#238
Conversation
Adds optional idpPostLogoutRedirectUrl (absolute override) and idpDisablePostLogoutRedirect (omit the parameter entirely) to AuthConfig for IdPs whose allowed post-logout URLs are fixed or which reject any non-registered URL. Precedence: disable > absolute URL > derived default. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
release() now defers teardown by a 60s grace period instead of destroying the engine the moment refCount hits 0; acquire() cancels the pending teardown. Preview open/close and table-to-table navigation reuse the warm engine, so the WASM is not re-fetched/re-instantiated and extensions are not reloaded each time. forceDestroy()/resetDatabase() still tear down now. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 33 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe PR defers LoQE engine destruction across brief idle periods and adds configurable OIDC post-logout redirect behavior through new authentication settings. ChangesLoQE engine lifecycle
OIDC logout redirect configuration
Estimated code review effort: 3 (Moderate) | ~20 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/plugins/auth.ts`:
- Around line 39-42: Update the Cognito branch in signOut to honor
config.idpDisablePostLogoutRedirect instead of falling back to
window.location.origin when post_logout_redirect_uri is undefined. Preserve the
existing logout_uri behavior when the flag is false, and ensure the disabled
state omits or otherwise avoids supplying a redirect URI.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c9ca0ca2-0195-4786-a41e-c937fc18fb7e
📒 Files selected for processing (2)
src/composables/loqe/LoQEEngine.tssrc/plugins/auth.ts
The Cognito branch fell back to window.location.origin for logout_uri when post_logout_redirect_uri was undefined, so idpDisablePostLogoutRedirect was ignored for Cognito. Now omit logout_uri entirely when the redirect is disabled; keep the existing behavior (client_id + logout_uri) otherwise. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
What
Two independent changes:
Post-logout redirect override (
auth.ts) — adds optionalidpPostLogoutRedirectUrl(absolute override) andidpDisablePostLogoutRedirect(omit thepost_logout_redirect_uriparam entirely) toAuthConfig, for IdPs whose allowed post-logout URLs are fixed or which reject any non-registered URL. Precedence: disable > absolute URL > derived default. Fully backward compatible (both fields optional).Keep LoQE DuckDB engine warm (
LoQEEngine.ts) —release()now defers teardown by a 60s grace period instead of destroying the engine the instant refCount hits 0;acquire()cancels the pending teardown. Preview open/close and table-to-table navigation reuse the warm engine, so the DuckDB WASM is not re-fetched/re-instantiated and extensions are not reloaded each time.forceDestroy()/resetDatabase()still tear down immediately.BEGIN_COMMIT_OVERRIDE
feat(ui): add post-logout redirect override and disable options to auth config
fix(ui): keep LoQE DuckDB engine warm across previews with grace-period teardown
END_COMMIT_OVERRIDE
Summary by CodeRabbit
New Features
Bug Fixes