feat: post-logout redirect override#349
Conversation
Reads two new env vars and passes them to createAuth: - VITE_IDP_POST_LOGOUT_REDIRECT_URL (absolute override) - VITE_IDP_POST_LOGOUT_REDIRECT_DISABLED (omit the parameter entirely) The DISABLED bool is injected via the index.html globalThis.__lknologout global (with a placeholder-mode Vite define) so the minifier does not constant-fold the placeholder away; the URL string travels in the bundle like the other OIDC settings. console-rs substitutes both placeholders at serve time, mirroring the existing auth/perms/branding pattern. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 53 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. WalkthroughAdds URL and disable-redirect configuration for identity-provider logout flows, propagates the settings into auth initialization, and injects them into embedded frontend assets and placeholder-mode startup configuration. ChangesPost-logout redirect configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant Environment
participant AppConfig
participant AuthPlugin
participant ConsoleServer
participant Frontend
Environment->>AppConfig: Read post-logout settings
AppConfig->>AuthPlugin: Pass settings to createAuth
ConsoleServer->>Frontend: Inject post-logout placeholders
Frontend->>AuthPlugin: Use configured logout behavior
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…aceholder The CI key-parity check extracts everything before `=` per line, so comment lines count as keys and break the diff against .env.placeholder (which has none). Keep .env keys-only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
What
Adds two new env vars and passes them to
createAuth:VITE_IDP_POST_LOGOUT_REDIRECT_URL— absolute override forpost_logout_redirect_uriVITE_IDP_POST_LOGOUT_REDIRECT_DISABLED— omit the parameter entirely (RFC-optional)For IdPs whose allowed post-logout URLs are fixed (e.g. a cloud portal login page) or which reject any non-registered URL.
The
DISABLEDbool is injected via theindex.htmlglobalThis.__lknologoutglobal plus a placeholder-mode Vitedefine, so the minifier does not constant-fold the placeholder away (same pattern as__lkauth/__lkperm). The URL string rides in the JS bundle like the other OIDC settings.console-rssubstitutes both placeholders at serve time.Depends on
The console-components auth changes (lakekeeper/console-components#238). Bump the
@lakekeeper/console-componentsrev to the release that includes those fields before merging — CI will fail against the current v0.16.0 pin until then.BEGIN_COMMIT_OVERRIDE
feat(ui): add post-logout redirect override and disable options
END_COMMIT_OVERRIDE
Summary by CodeRabbit