Skip to content

feat: post-logout redirect override#349

Merged
v-kessler merged 3 commits into
mainfrom
feat/idp-post-logout-override
Jul 12, 2026
Merged

feat: post-logout redirect override#349
v-kessler merged 3 commits into
mainfrom
feat/idp-post-logout-override

Conversation

@v-kessler

@v-kessler v-kessler commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

What

Adds two new env vars and passes them to createAuth:

  • VITE_IDP_POST_LOGOUT_REDIRECT_URL — absolute override for post_logout_redirect_uri
  • VITE_IDP_POST_LOGOUT_REDIRECT_DISABLED — omit the parameter entirely (RFC-optional)

For IdPs whose allowed post-logout URLs are fixed (e.g. a cloud portal login page) or which reject any non-registered URL.

The DISABLED bool is injected via the index.html globalThis.__lknologout global plus a placeholder-mode Vite define, so the minifier does not constant-fold the placeholder away (same pattern as __lkauth/__lkperm). The URL string rides in the JS bundle like the other OIDC settings. console-rs substitutes both placeholders at serve time.

Depends on

The console-components auth changes (lakekeeper/console-components#238). Bump the @lakekeeper/console-components rev to the release that includes those fields before merging — CI will fail against the current v0.16.0 pin until then.

BEGIN_COMMIT_OVERRIDE
feat(ui): add post-logout redirect override and disable options
END_COMMIT_OVERRIDE

Summary by CodeRabbit

  • New Features
    • Added configurable post-logout redirect behavior for identity-provider sign-outs.
    • Administrators can specify an absolute redirect URL or disable the post-logout redirect entirely.
    • Added support for these settings across standard and placeholder deployments.
  • Bug Fixes
    • Improved consistency of logout handling by ensuring configured redirect settings are applied during authentication startup.
  • Chores
    • Updated the console components package to version 0.17.0.

Reads two new env vars and passes them to createAuth:
- VITE_IDP_POST_LOGOUT_REDIRECT_URL (absolute override)
- VITE_IDP_POST_LOGOUT_REDIRECT_DISABLED (omit the parameter entirely)

The DISABLED bool is injected via the index.html globalThis.__lknologout
global (with a placeholder-mode Vite define) so the minifier does not
constant-fold the placeholder away; the URL string travels in the bundle
like the other OIDC settings. console-rs substitutes both placeholders at
serve time, mirroring the existing auth/perms/branding pattern.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@v-kessler, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 44918055-6ec4-4264-8796-03f936b3c21b

📥 Commits

Reviewing files that changed from the base of the PR and between e20b981 and a415fa1.

📒 Files selected for processing (1)
  • .env

Walkthrough

Adds URL and disable-redirect configuration for identity-provider logout flows, propagates the settings into auth initialization, and injects them into embedded frontend assets and placeholder-mode startup configuration.

Changes

Post-logout redirect configuration

Layer / File(s) Summary
Configuration and auth wiring
.env, .env.placeholder, src/app.config.ts, src/main.ts, package.json, src/assets/dependencies.json
Adds post-logout environment settings, exports parsed values, passes them to createAuth, and updates console components to version 0.17.0.
Embedded asset placeholder rendering
console-rs/src/lib.rs
Adds Rust configuration fields, defaults, template substitutions, and rendered-output test coverage for the new settings.
Placeholder startup wiring
index.html, vite.config.mts
Maps the disabled-redirect placeholder through the startup global and Vite placeholder-mode definitions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Environment
  participant AppConfig
  participant AuthPlugin
  participant ConsoleServer
  participant Frontend
  Environment->>AppConfig: Read post-logout settings
  AppConfig->>AuthPlugin: Pass settings to createAuth
  ConsoleServer->>Frontend: Inject post-logout placeholders
  Frontend->>AuthPlugin: Use configured logout behavior
Loading

Possibly related PRs

Poem

A bunny hops through logout light,
With redirect paths tucked in tight.
Flags bloom where placeholders grow,
Auth knows which way to go.
Configured hops, a smoother flight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding post-logout redirect override support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/idp-post-logout-override

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

v-kessler and others added 2 commits July 12, 2026 17:03
…aceholder

The CI key-parity check extracts everything before `=` per line, so comment
lines count as keys and break the diff against .env.placeholder (which has
none). Keep .env keys-only.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@v-kessler
v-kessler merged commit 044ce1f into main Jul 12, 2026
7 checks passed
@v-kessler
v-kessler deleted the feat/idp-post-logout-override branch July 12, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant