topk: add top-k kernel for MoE routers on Metal - #1124
Conversation
|
@SunMarc could we rename it to |
|
@SunMarc could we rename it to topk-metal or something to denote the specificity? I named it this way because there was a change that i might add cuda kerrnels in it. |
|
/kernel-builder build-and-stage topk |
|
/kernel-bot build-and-stage topk |
|
Build request processed. Command: Dispatched (1):
Hub uploads: |
`kernel_maintainers.py check` requires every directory with a `build.toml` to appear in the registry, so the new kernel failed CI until it was listed. The card is the same template the other 51 kernels ship, and `CARD.md` is the name they all use.
|
can you build and stage again @sayakpaul ? i've fixed a few things since the CI wasn't happy (e.g kernels-maintainers.json) |
|
/kernel-bot build-and-stage topk |
|
Build request processed. Command: Dispatched (1):
Hub uploads: |
|
@SunMarc I just did. But more generally, let's first confirm it can build successfully (which you can trigger as well). Then we can just do |
|
Oh nice, always thought that we had to stage before ! thanks for letting me know |
2 participants
What does this PR do ?
This PR adds better topk kernel on metal