Skip to content

ggml-quantization: add llama.cpp GGUF quantization kernels for Metal - #1120

Merged
github-actions[bot] merged 1 commit into
huggingface:mainfrom
SunMarc:add-ggml-quantization
Sep 2, 2026
Merged

github-actions[bot] merged 1 commit into
huggingface:mainfrom
SunMarc:add-ggml-quantization

Conversation

@SunMarc

@SunMarc SunMarc commented Aug 28, 2026

Copy link
Copy Markdown
Member

What does this PR do ?

This PR adds kernels from llamacpp related to quantization for metal only.

@github-actions github-actions Bot added the chore Version bumps, releases, misc maintenance label Aug 28, 2026
@SunMarc
SunMarc force-pushed the add-ggml-quantization branch 2 times, most recently from 37b7a60 to 78f269e Compare August 28, 2026 17:28
@SunMarc

SunMarc commented Aug 28, 2026

Copy link
Copy Markdown
Member Author

cc @sayakpaul

backends = ["metal"]

[general.hub]
repo-id = "kernels-community/ggml-quantization"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for now but should we have this under the GGML org?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm for now, i think it is better to have it here as it will be easier to maintain no ?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GGML is HF :) So, even kernels-community is easier to maintain, we should be cognizant about growing kernels out of that single HF org. So, I think we should consider it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind moving it to ggml but maybe let's see if this takes off or not before moving them to ggml org ? Both are fine to me cc @LysandreJik if you have a preference

@sayakpaul

Copy link
Copy Markdown
Member

/kernel-bot build-and-stage ggml-quantization

@github-actions

github-actions Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build-and-stage ggml-quantization
Mode: build and stage
Target branch: pr-1120
PR head SHA: 1ad0d41d4e4bf078908f886359444eeb08fc0c5e
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

sayakpaul
sayakpaul previously approved these changes Aug 31, 2026

@sayakpaul sayakpaul left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be better to have this with #1124 in a single PR.

@SunMarc
SunMarc force-pushed the add-ggml-quantization branch 2 times, most recently from e7c90a3 to ddc9bf3 Compare August 31, 2026 10:37
@SunMarc

SunMarc commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

/kernel-bot build ggml-quantization

@github-actions

github-actions Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build ggml-quantization
Mode: build only
Target branch: pr-1120
PR head SHA: ddc9bf305ead0ffa5777948d18c15cbe4e29534a
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

@SunMarc

SunMarc commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

Since the topk is a different package not related to ggml, i prefer to keep it seperate

@SunMarc
SunMarc force-pushed the add-ggml-quantization branch 2 times, most recently from 0ae07b6 to ac88f29 Compare September 2, 2026 09:00
@sayakpaul

Copy link
Copy Markdown
Member

/kernel-bot build-and-stage ggml-quantization

@sayakpaul

Copy link
Copy Markdown
Member

@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot build-and-stage ggml-quantization
Mode: build and stage
Target branch: pr-1120
PR head SHA: ac88f294779ec715330ecc0d1caa3ab0c537f3d0
Workflows: build.yaml, build-mac.yaml, build-windows.yaml

Dispatched (1):

Hub uploads:

@SunMarc
SunMarc force-pushed the add-ggml-quantization branch from ac88f29 to fb04d63 Compare September 2, 2026 09:31
@sayakpaul

Copy link
Copy Markdown
Member

/kernel-bot merge-and-upload ggml-quantization

@github-actions

github-actions Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Build request processed.

Command: /kernel-bot merge-and-upload ggml-quantization
Mode: merge, build and upload
Target branch: ``
PR head SHA: fb04d639419aa9d096d6078b08c41856b72052bf
Workflows: `build.yaml, build-mac.yaml, build-windows.yaml`

Merge result: Pull Request successfully merged

Dispatched (1):

Hub uploads:

@github-actions
github-actions Bot merged commit 63f3c1e into huggingface:main Sep 2, 2026
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Version bumps, releases, misc maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants