Skip to content

[Snyk] Fix for 4 vulnerabilities #10049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
q1blue wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Fix for 4 vulnerabilities #10049

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/stack-overflow-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",
Comment on lines +35 to +37
Copy link

@gemini-code-assist gemini-code-assist bot Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These automated dependency changes are incorrect and should be rejected for several reasons:

  1. Breaks Monorepo Strategy: Replacing workspace:^ with pinned versions goes against the Yarn workspace dependency strategy, which can lead to version conflicts and maintenance issues.
  2. Critical Downgrade: The version of @backstage/plugin-search-common is being downgraded from 1.2.5 (workspace version) to 0.3.1. This is a major regression that will almost certainly break the application.
  3. Incomplete Change: The PR description states that yarn.lock was not updated, which is a required step after changing dependencies.

These vulnerabilities should be addressed by performing a proper dependency update across the workspace, not through these problematic pinned versions.

"node-fetch": "^2.6.7",
"qs": "^6.9.4",
"winston": "^3.2.1"
Expand Down
Loading