Skip to content

[Snyk] Fix for 4 vulnerabilities#10049

Open
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-162ba80bd2575817c89f452ee1beaab3
Open

[Snyk] Fix for 4 vulnerabilities#10049
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-162ba80bd2575817c89f452ee1beaab3

Conversation

@q1blue
Copy link
Collaborator

@q1blue q1blue commented Jan 19, 2026

snyk-top-banner

Snyk has created this PR to fix 4 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/stack-overflow-backend/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Use of a Cryptographic Primitive with a Risky Implementation
SNYK-JS-ELLIPTIC-14908844
  146  
high severity Cross-site Scripting (XSS)
SNYK-JS-REMIXRUNROUTER-14908530
  134  
high severity Open Redirect
SNYK-JS-REACTROUTER-14908286
  114  
high severity Open Redirect
SNYK-JS-REMIXRUNROUTER-14908287
  114  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Open Redirect
🦉 Cross-site Scripting (XSS)

@codesandbox
Copy link

codesandbox bot commented Jan 19, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, addresses critical security concerns by upgrading specific dependencies within the plugins/stack-overflow-backend module. The primary goal is to remediate four vulnerabilities, including high-severity Cross-site Scripting and Open Redirect issues, by updating @backstage/backend-common and @backstage/plugin-search-common to their patched versions.

Highlights

  • Dependency Updates: The pull request updates @backstage/backend-common from workspace:^ to 0.24.1 and @backstage/plugin-search-common from workspace:^ to 0.3.1 in the plugins/stack-overflow-backend/package.json file.
  • Vulnerability Fixes: These dependency updates are intended to fix 4 identified vulnerabilities: one medium severity (Use of a Cryptographic Primitive with a Risky Implementation) and three high severity (Cross-site Scripting (XSS) and Open Redirect).
  • Manual yarn.lock Update Required: The yarn.lock file failed to update automatically, requiring a manual update before merging to ensure consistency across environments.
  • Zero-Installs Consideration: Users employing Yarn's zero-installs feature will need to run yarn after pulling this PR to update the .yarn/cache/ directory, as it was not updated automatically.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link

snyk-io bot commented Jan 19, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix four security vulnerabilities by updating dependencies. However, the proposed changes are problematic for this monorepo. It replaces workspace-relative dependencies (workspace:^) with pinned versions, which goes against the monorepo's dependency management strategy and can cause inconsistencies. More critically, it severely downgrades the @backstage/plugin-search-common package, which will likely break the application. The PR also notes that the yarn.lock file was not updated. I recommend rejecting these changes and addressing the vulnerabilities manually by updating the dependencies across the workspace correctly.

Comment on lines +35 to +37
"@backstage/backend-common": "0.24.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These automated dependency changes are incorrect and should be rejected for several reasons:

  1. Breaks Monorepo Strategy: Replacing workspace:^ with pinned versions goes against the Yarn workspace dependency strategy, which can lead to version conflicts and maintenance issues.
  2. Critical Downgrade: The version of @backstage/plugin-search-common is being downgraded from 1.2.5 (workspace version) to 0.3.1. This is a major regression that will almost certainly break the application.
  3. Incomplete Change: The PR description states that yarn.lock was not updated, which is a required step after changing dependencies.

These vulnerabilities should be addressed by performing a proper dependency update across the workspace, not through these problematic pinned versions.

@entelligence-ai-pr-reviews
Copy link

Walkthrough

Changes

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant Local as Local Workspace
    participant Registry as NPM Registry
    participant Plugin as stack-overflow-backend

    Note over Dev,Plugin: Dependency Resolution Change

    Dev->>PM: npm install / yarn install
    
    alt Before Change (workspace:^)
        PM->>Local: Resolve @backstage/backend-common
        Local-->>PM: Return local workspace version
        PM->>Local: Resolve @backstage/plugin-search-common
        Local-->>PM: Return local workspace version
    else After Change (specific versions)
        PM->>Registry: Request @backstage/backend-common@0.24.1
        Registry-->>PM: Return package version 0.24.1
        PM->>Registry: Request @backstage/plugin-search-common@0.3.1
        Registry-->>PM: Return package version 0.3.1
    end
    
    PM->>Plugin: Install resolved dependencies
    Note over Plugin: Dependencies now pinned<br/>to specific versions
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

@github-actions
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments