Skip to content

Some README updates - #6473

Merged
dscho merged 6 commits into
git-for-windows:mainfrom
dscho:no-more-gitter
Oct 26, 2026
Merged

dscho merged 6 commits into
git-for-windows:mainfrom
dscho:no-more-gitter

Conversation

@dscho

@dscho dscho commented Oct 9, 2026

Copy link
Copy Markdown
Member

I noticed that the Gitter badge is misleading, as it suggests that any Git for Windows maintainer hangs out there, but we don't.

Also, the GitHub Actions badge seems to have been broken for quite a while and suggested that the CI failed (which it did not).

@dscho
dscho requested review from mjcheetham and rimrul October 9, 2026 06:59
@dscho dscho self-assigned this Oct 9, 2026
dscho added 2 commits October 25, 2026 19:59
We haven't been on Gitter in quite a while. Let's remove the misleading
badge.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Apparently the badge URL has changed at some stage. I must have missed
this, and I do not regularly look at that badge. But when I did, I saw
that it says "failing" even though the CI runs were successful (I
checked, after re-enabling Actions in git-for-windows/git that GitHub so
helpfully "disabled [...] on this forked repository because of its
Actions usage").

So I followed the guidance (or more correctly: **tried* to follow) at
https://docs.github.com/en/actions/how-tos/monitor-workflows/add-a-status-badge,
which kind of worked after not finding the promised `⋯` menu but
realizing that there was a section on how to manually construct the URL.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
pks-t and others added 2 commits October 25, 2026 21:03
The linux32 job is used to exercise Git on a 32 bit platform. That job
uses i386/ubuntu:20.04 though, and that version of Ubuntu is end of life
nowadays. Furthermore, Ubuntu 20.04 is the last release that has support
for 32 bit, so we cannot upgrade the image to a later version, either.

Switch the job over to use i386/debian instead. Note that starting with
Debian 13, support for i386 has been reduced [1]. But Debian still
releases 32 bit Docker images for the latest release nowadays, so we
will have coverage until at least 2030.

[1]: https://www.debian.org/releases/trixie/release-notes/issues.en.html#i386-reduced-support

Backported from a8dc3aa (ci: switch away from unsupported
i386/ubuntu image, 2026-10-15).

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Since 00fa850 (ci: bump debian-11 job to debian-12, 2026-09-05), the
`debian-12` job has intermittently failed t5559's half-auth clone with:

  curl 92 Stream error in the HTTP/2 framing layer

Anonymous discovery succeeds, but the upload-pack POST requires
authentication. Apache can return an early 401 and close the HTTP/2
stream before libcurl finishes sending the request body. Debian 12's
curl 7.88.1 treats that closure as a transport error instead of allowing
an authentication retry. Curl fixed this handling in 331b89a319d0
(http2: polish things around POST), included in 8.3.0:
curl/curl#11756

This did not happen before switching to Debian 12 because Debian 11
ships with libcurl 7.74.0-1.3+deb11u16, which does not have that bug, it
was only introduced in cURL 7.88.0.

Replacing the packaged libcurl with a modern build would defeat this
job's purpose of testing older supported distributions. So let's simply
skip the flaky test cases when a buggy libcurl version is detected.

Backported from 64172cf (ci: work around Debian 12's HTTP/2
authentication failures, 2026-09-24) with e2d64bd (t5551: fix
quoting in curl version bug prereq, 2026-10-05) squashed in.

Assisted-by: GPT-6 Astra, GPT-6 Sol
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho

dscho commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

Sadly, new CI stuff cropped up that seems to require additional patches to let the PR build succeed:

  • documentation, static-analysis, fuzz smoke test: ci/install-dependencies.sh:87 replaces /usr/bin/dirname without elevated privileges.
  • linux32: The runner manifest confirms Docker 29.4.2. Its seccomp profile blocks socketcall, breaking i386 networking, which is a regression reported in Ubuntu 26.04: Docker 29.4.2 blocks socketcall, so i386 containers have no network actions/runner-images#14790. The missing-package errors follow from failed DNS resolution. I guess we could pin this job’s host to ubuntu-24.04...
  • debian-12: libcurl 7.88.1 mishandles an early HTTP/2 authentication response. t5559.15 fails; .16 then fails because the clone never existed. This exactly matches gitgitgadget/git#2236.

When replacing `dirname`, elevation is required, otherwise the command
will fail with:

  + ln -sfT /usr/bin/gnudirname /usr/bin/dirname
  ln: failed to create symbolic link '/usr/bin/dirname': Already exists

as observed in
https://github.com/git-for-windows/git/actions/runs/40223871341/job/121274294974?pr=6473#step:3:909

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho added this to the v2.56.0(4) milestone Oct 25, 2026
@dscho

dscho commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

For the record: I plan on using this here PR to build and release Git for Windows v2.56.0(4) tomorrow.

The linux32 job fails DNS resolution before checkout because Docker
29.4.2's seccomp profile on Ubuntu 26.04 blocks socketcall in i386 glibc
containers. Ubuntu 24.04 avoids this host-side regression.

actions/runner-images#14790

Assisted-by: GPT-6.1 Sol
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho

dscho commented Oct 26, 2026 •

Copy link
Copy Markdown
Member Author

/add relnote blurb This is another urgent security bug fix release, addressing CVE-2026-111497.

The workflow run was started

@dscho

dscho commented Oct 26, 2026 •

Copy link
Copy Markdown
Member Author

/git-artifacts

The tag-git workflow run was started

The git-artifacts-x86_64 workflow run was started.
The git-artifacts-i686 workflow run was started.
The git-artifacts-aarch64 workflow run was started.
The git-artifacts-mingw64 workflow run was started.

@gitforwindowshelper

Copy link
Copy Markdown

Validate the installer manually

The installer was built successfully;
Please download, install, and run through the pre-flight check-list.
@dscho ☝️

@dscho dscho linked an issue Oct 26, 2026 that may be closed by this pull request
1 task done
@dscho

dscho commented Oct 26, 2026 •

Copy link
Copy Markdown
Member Author

/release

The release-git workflow run was started

@gitforwindowshelper

Copy link
Copy Markdown

@dscho, please Share on Bluesky and send the announcement email.

Please wait for the repository-updates job to finish, then open the MSYS2 sync PR.

@dscho
dscho merged commit 5812916 into git-for-windows:main Oct 26, 2026
86 checks passed
@dscho
dscho deleted the no-more-gitter branch October 26, 2026 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bundled brotli is still 1.2.0 in 2.56.0.windows.3 (CVE-2026-111497 is fixed in 1.2.1)

3 participants